Bug 1094553

Summary: timeouts not enforced when beaker-provision is fetching images for configure_netboot
Product: [Retired] Beaker Reporter: Dan Callaghan <dcallagh>
Component: lab controllerAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 0.16CC: aigao, asaha, dcallagh, rmancy, xma
Target Milestone: 0.17.1   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-18 08:17:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dan Callaghan 2014-05-06 03:04:23 UTC
beaker-provision does not enforce any read timeout when fetching images for the configure_netboot command.

That means if the HTTP server is misbehaving and never returns a response, the configure_netboot command could end up stuck in limbo until beaker-provision is restarted.

Comment 2 Dan Callaghan 2014-06-25 03:34:12 UTC
On Gerrit: http://gerrit.beaker-project.org/3171

Comment 4 Dan Callaghan 2014-06-26 06:25:38 UTC
Verifying this outside of devel is quite difficult. You would need to edit a distro tree's URLs to point at a custom HTTP server which accepts requests but then waits forever without sending a response or closing the connection. The expected result is that beaker-provision eventually reports that the command failed with "urlopen timed out".

There is a reproducer in the test suite, using a fake HTTP server. I don't think it's worth trying to verify the fix by hand in a real environment.

Comment 6 Dan Callaghan 2014-07-18 08:17:46 UTC
Beaker 0.17.1 has been released.