Bug 1094804

Summary:	Review Request: pam_script - PAM module for executing scripts
Product:	[Fedora] Fedora	Reporter:	Jason Taylor <jtfas90>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DEFERRED	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-05-09 15:34:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jason Taylor 2014-05-06 14:14:51 UTC

Spec URL: https://github.com/jmtaylor90/pam-script-rpm/blob/master/specs/pam-script.spec
SRPM URL: https://github.com/jmtaylor90/pam-script-rpm/blob/master/rpm/pam-script-1.1.7-1.fc20.src.rpm
Description: pam_script is a module which allows to execute scripts after opening
and/or closing a session using PAM.

Fedora Account System Username: jtaylor

History:

https://bugzilla.redhat.com/show_bug.cgi?id=624705

This is my first package and need a sponsor. The goal is to have this package in Fedora and EPEL 5/6. Successful koji scratch builds can be found here:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6818625 (f20)

http://koji.fedoraproject.org/koji/taskinfo?taskID=6818641 (el6)

http://koji.fedoraproject.org/koji/taskinfo?taskID=6818658 (el5)

Comment 1 Michael Cronenworth 2014-05-06 14:49:44 UTC

Looks good. One note: Your Source0 line needs either a comment or adjusting.

See: http://fedoraproject.org/wiki/Packaging:SourceURL#Github

Comment 2 Jason Taylor 2014-05-06 15:07:44 UTC

Thanks for the review Michael! I have updated the spec file and resultant srpm as indicated. 

https://github.com/jmtaylor90/pam-script-rpm/blob/master/specs/pam-script.spec

https://github.com/jmtaylor90/pam-script-rpm/blob/master/rpm/pam-script-1.1.7-1.fc20.src.rpm

JT

Comment 3 Christopher Meng 2014-05-06 15:10:48 UTC

Use your real name in Bugzilla, not only an email address.

This package should be named pam_script instead of the current one you are using.

Comment 4 Jason Taylor 2014-05-06 15:53:43 UTC

Thanks Christopher! I have made the adjustments as requested, the links now reflect the latest changes.

https://github.com/jmtaylor90/pam-script-rpm/blob/master/specs/pam_script.spec

https://github.com/jmtaylor90/pam-script-rpm/blob/master/rpm/pam_script-1.1.7-1.fc20.src.rpm

Comment 5 Jason Taylor 2014-05-06 18:16:42 UTC

scratch builds with the updated spec and src rpm are successful:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6819858 (f20)

http://koji.fedoraproject.org/koji/taskinfo?taskID=6819874 (el6)

http://koji.fedoraproject.org/koji/taskinfo?taskID=6819892 (el5)

Comment 6 Christopher Meng 2014-05-08 12:04:25 UTC

Follow this link step by step:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers

Be careful when you read the lines.

Thanks.

Comment 7 Jason Taylor 2014-05-08 12:51:00 UTC

Thanks Christopher,

I am reviewing again.

Comment 8 Jason Taylor 2014-05-09 15:34:07 UTC

Discovered this package needs some more work. Will refine and resubmit.