Bug 1095204

Summary: qcow should not be in error info when use virt-image create a guest with invalid disk format in XML
Product: Red Hat Enterprise Linux 6 Reporter: zhoujunqin <juzhou>
Component: python-virtinstAssignee: Giuseppe Scrivano <gscrivan>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.6CC: codong, dyuan, gscrivan, lcui, mzhan, tzheng, zsong
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-virtinst-0.600.0-22.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-14 06:24:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description zhoujunqin 2014-05-07 09:38:04 UTC
Description of problem:
qcow should not be in error info when use virt-image create a guest with invalid disk format in XML

Version-Release number of selected component (if applicable):
virt-manager-0.9.0-21.el6.x86_64
python-virtinst-0.600.0-21.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1.Prepare a virtual image XML descriptor file with an invalid disk format, such as "aaaa".
# cat image.xml
<image>
<name>demo</name>
<domain>
<boot type="hvm">
<guest>
<arch>x86_64</arch>
</guest>
<os>
<loader dev="hd"/>
</os>
<drive disk="mydisk" target="hda"/>
</boot>
<devices>
<vcpu>1</vcpu>
<memory>262144</memory>
<graphics/>
</devices>
</domain>
<storage>
<disk id="mydisk" file="/var/lib/libvirt/images/rr66.img" use="system" format="aaaa"/>
</storage>
</image>

2.Create a virtual machine from image.xml
# virt-image image.xml
ERROR    Cannot parse 'image.xml': The format for disk /var/lib/libvirt/images/rr66.img must be one of raw,qcow,qcow2,vmdk,iso

3.Check the format description in manual.
#man 5 virt-image
...
       ·   the format attribute giving the format of the disk file. Currently, this can be one of: "raw", "iso",
           "qcow2", or "vmdk".
...

Actual results:
The format for disk /var/lib/libvirt/images/rr66.img must be one of raw,qcow,qcow2,vmdk,iso.

Expected results:
Error message should not include "qcow" format inside.
Additional info:

Comment 4 zhoujunqin 2014-05-20 02:50:07 UTC
I can reproduce with package:
python-virtinst-0.600.0-21.el6.noarch
verified with new build:
python-virtinst-0.600.0-22.el6.noarch

steps:
1.Prepare a virtual image XML descriptor file with an invalid disk format, such as "aaaa".

# cat images.xml 
<image>
<name>demo</name>
<domain>
<boot type="hvm">
<guest>
<arch>x86_64</arch>
</guest>
<os>
<loader dev="hd"/>
</os>
<drive disk="mydisk" target="hda"/>
</boot>
<devices>
<vcpu>1</vcpu>
<memory>262144</memory>
<graphics/>
</devices>
</domain>
<storage>
<disk id="mydisk" file="/var/lib/libvirt/images/test1.img" use="system" format="aaaa"/>
</storage>
</image>
2.Create a virtual machine from image.xml

# virt-image images.xml 
ERROR    Cannot parse 'images.xml': The format for disk /var/lib/libvirt/images/test1.img must be one of raw,qcow2,vmdk,iso

Since the format showing is coincident with manual page.
# man 5 virt-image
       ·   the format attribute giving the format of the disk file. Currently,
           this can be one of: "raw", "iso", "qcow2", or "vmdk".
there is no "qcow" format showing, move to verified.

Comment 5 errata-xmlrpc 2014-10-14 06:24:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1444.html