Bug 1096072
| Summary: | Review Request: nodejs-sprintf - JavaScript sprintf implementation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | anish <apatil> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade, petersen |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-sprintf-0.1.4-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-08-08 08:40:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1096052 | ||
|
Description
anish
2014-05-09 08:08:09 UTC
Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-sprintf.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-sprintf.noarch: W: only-non-binary-in-usr-lib nodejs-sprintf.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha256sum) srpm tarball :d77c7808d66a10a063eff55d36bb74ea383b84f219d42bb2378df031a2c89803 upstream tarball : d77c7808d66a10a063eff55d36bb74ea383b84f219d42bb2378df031a2c89803 + License "MIT" is valid and is included in its own file as %doc + rest looks following packaging guidelines Suggestions: 1) you can drop Group tag for Fedora releases. 2) Good to add following in %prep %nodejs_fixdep 3) Good to add following in %install %nodejs_symlink_deps Hi Parag Thank you for your review comments, I have incorporated first comment. However i can't incorporate comment 2 and 3 because package.json is not updated in released tarball by upstream. Updated https://github.com/maritz/node-sprintf/blob/master/package.json is in git repo but not on tarball Spec URL: http://anishpatil.fedorapeople.org/nodejs-sprintf.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-sprintf-0.1.3-2.fc20.src.rpm Hi Parag thank you for your help Please find updated spec and SRPM on Spec URL: http://anishpatil.fedorapeople.org/nodejs-sprintf.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-sprintf-0.1.3-3.fc20.src.rpm Looks good now. APPROVED. Thanks Parag for review New Package SCM Request ======================= Package Name: nodejs-sprintf Short Description: JavaScript sprintf implementation Upstream URL: https://github.com/maritz/node-sprintf Owners: anishoatik Branches: f20 f21 InitialCC: i18n-team Correct owners name in earlier comment New Package SCM Request ======================= Package Name: nodejs-sprintf Short Description: JavaScript sprintf implementation Upstream URL: https://github.com/maritz/node-sprintf Owners: anishpatil Branches: f20 f21 InitialCC: i18n-team Git done (by process-git-requests). nodejs-sprintf-0.1.3-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-sprintf-0.1.3-3.fc20 nodejs-sprintf-0.1.3-3.fc20 has been pushed to the Fedora 20 testing repository. nodejs-sprintf-0.1.3-3.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: nodejs-sprintf New Branches: el6 epel7 Owners: anishpatil InitialCC: i18n-team Git done (by process-git-requests). nodejs-sprintf-0.1.4-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-sprintf-0.1.4-1.el7 nodejs-sprintf-0.1.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-sprintf-0.1.4-1.el6 nodejs-sprintf-0.1.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. nodejs-sprintf-0.1.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |