Bug 1096312

Summary:	log spam in vdsm: guest agents not heartbeating
Product:	[oVirt] vdsm	Reporter:	Sven Kieske <s.kieske>
Component:	General	Assignee:	Vinzenz Feenstra [evilissimo] <vfeenstr>
Status:	CLOSED CURRENTRELEASE	QA Contact:	sefi litmanovich <slitmano>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	---	CC:	bazulay, bugs, gklein, mgoldboi, michal.skrivanek, rbalakri, vfeenstr, yeylon, ylavi
Target Milestone:	ovirt-3.6.0-rc	Keywords:	EasyFix
Target Release:	4.17.8	Flags:	rule-engine: ovirt-3.6.0+ ylavi: planning_ack+ rule-engine: devel_ack+ mavital: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	virt
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-10 12:53:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sven Kieske 2014-05-09 15:57:44 UTC

Description of problem:
Thread-25::DEBUG::2014-05-02
09:02:43,652::fileSD::222::Storage.Misc.excCmd::(getReadDelay) '/bin/dd
iflag=direct
if=/rhev/data-center/mnt/_home_DATA/9dc0fcb5-b0b0-47dd-b41f-d8709fd8cab2/dom_md/metadata
bs=4096
count=1' (cwd None)
Thread-25::DEBUG::2014-05-02
09:02:43,667::fileSD::222::Storage.Misc.excCmd::(getReadDelay) SUCCESS:
<err> = '0+1 records in\n0+1 records out\n495 bytes (495 B) copied,
0.000160501 s, 3.1 MB/s\n'; <rc> = 0
VM Channels Listener::DEBUG::2014-05-02
09:02:43,940::vmChannels::91::vds::(_handle_timeouts) Timeout on fileno 65.
VM Channels Listener::DEBUG::2014-05-02
09:02:45,384::vmChannels::91::vds::(_handle_timeouts) Timeout on fileno 106.


Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:
log spam

Expected results:
no log spam

Additional info:
see this thread on devel:
http://lists.ovirt.org/pipermail/devel/2014-May/007289.html

Comment 1 Dan Kenigsberg 2014-05-09 22:14:16 UTC

virt.vmchannels.Listener should keep track which of its channels have seen a timeout, and avoid re-logging further timeouts. Once a channel has seen an event, its "timeoutSeen" flag should be cleared.

Comment 2 Sven Kieske 2014-06-18 08:26:25 UTC

any reason this is targeted to 3.6 ? I guess it could get easily backported
in 3.4.x tree?
This also needs some reviewers love.

Comment 3 Vinzenz Feenstra [evilissimo] 2014-06-18 11:42:41 UTC

It was targeted 3.6 because 3.5 is around the corner and we wanted it to be already for ages branched out.
The decision for backporting this is not on me. You could try to bump that on devel

Comment 4 Vinzenz Feenstra [evilissimo] 2014-08-18 07:18:48 UTC

Merged to upstream master as http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=commit;h=4b6d194186de88ad8c8901b59aacb3879ccf7eca

Comment 5 Red Hat Bugzilla Rules Engine 2015-10-18 08:34:29 UTC

Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA.

Comment 6 sefi litmanovich 2016-01-26 15:42:39 UTC

Verified with rhevm-3.6.2-0.1.el6.noarch and host with RHEL7.2 and vdsm-4.17.18-0.el7ev.noarch.

Start vm with no rhevm-guest-agent installed.
in vdsm log I can see:
VM Channels Listener::DEBUG::2016-01-26 17:37:56,502::vmchannels::99::vds::(_handle_timeouts) Timeout on fileno 37.

This message doesn't appear again for this channel.