Bug 1096349

Summary: Fix kmod.prov to work with compressed modules
Product: [Fedora] Fedora Reporter: Josh Boyer <jwboyer>
Component: redhat-rpm-configAssignee: Panu Matilainen <pmatilai>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: bruno, jonathan, kmcmartin, pmatilai
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-12 19:10:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1058331    
Attachments:
Description Flags
Strip compression suffixes from kmod Provides none

Description Josh Boyer 2014-05-09 17:52:31 UTC 
Created attachment 894131 [details]
Strip compression suffixes from kmod Provides

Description of problem:

With bug 1025513, Kyle added support to generate kmod(foo.ko) provides for kernel modules.  That works fine, however we're looking at shipping xz compressed modules.  That means the existing script would generate:

Provides: kmod(foo.ko.xz)

instead of

Provides: kmod(foo.ko)

(the modules.builtin provides aren't impacted).

We'll be compressing the modules with xz, but the userspace utilities can support xz or gzip.  The attached patch fixes the kmod.prov script to strip off the .gz/.xz suffix and generate the Provides we'd still like.

I've done a build in COPR against a redhat-rpm-config that has this patch included.  The provides appear to be generated correctly.  You can find the results here:

http://copr-be.cloud.fedoraproject.org/results/jwboyer/kernel-kmod-autoprov/fedora-rawhide-x86_64/kernel-3.15.0-0.rc4.git4.8.fc21.2/

If this looks OK to everyone, I can push it to git and kick off a build.
Comment 1 Bruno Wolff III 2014-05-09 20:00:16 UTC 
I did a quick check and the dependencies seemed to get resolved properly:
Resolving Dependencies
--> Running transaction check
---> Package joystick-support.noarch 0:1.0.0-10.2.fc21 will be installed
--> Processing Dependency: kmod(joydev.ko) for package: joystick-support-1.0.0-10.2.fc21.noarch
--> Running transaction check
---> Package kernel-PAE-modules-extra.i686 0:3.15.0-0.rc4.git4.8.fc21.2 will be installed
--> Finished Dependency Resolution
Comment 2 Panu Matilainen 2014-05-12 12:50:15 UTC 
(In reply to Josh Boyer from comment #0)
> If this looks OK to everyone, I can push it to git and kick off a build.

As for the script change, that's yours to change :)

For the spec part, please note that redhat-rpm-config modifications should always just bump the version and leave release alone (as commented at the top of the spec). Its unlike anything else yes, but then redhat-rpm-config is.
Comment 3 Josh Boyer 2014-05-12 13:02:34 UTC 
(In reply to Panu Matilainen from comment #2)
> (In reply to Josh Boyer from comment #0)
> > If this looks OK to everyone, I can push it to git and kick off a build.
> 
> As for the script change, that's yours to change :)

OK.

> For the spec part, please note that redhat-rpm-config modifications should
> always just bump the version and leave release alone (as commented at the
> top of the spec). Its unlike anything else yes, but then redhat-rpm-config
> is.

Ah, sorry.  Missed that.  I'll fix it before I commit/push.  Thanks Panu.
Comment 4 Josh Boyer 2014-05-12 19:10:25 UTC 
Pushed and built.