Bug 1096700

Summary:	[SNAPSHOT]: Quorum check should not be made for snapshot status command.
Product:	[Community] GlusterFS	Reporter:	Sachin Pandit <spandit>
Component:	glusterd	Assignee:	Sachin Pandit <spandit>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	bugs, gluster-bugs, nsathyan, rjoseph
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	SNAPSHOT
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1097157 (view as bug list)		Environment:
Last Closed:	2014-11-11 08:32:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1097157

Description Sachin Pandit 2014-05-12 09:25:39 UTC

Description of problem:

Snapshot status command fails with the error "snapname not found"
during quorum check.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-05-12 09:31:37 UTC

REVIEW: http://review.gluster.org/7737 (glusterd/snapshot : Quorum check should not be made for snapshot status command.) posted (#1) for review on master by Sachin Pandit (spandit)

Comment 2 Anand Avati 2014-05-12 09:35:36 UTC

REVIEW: http://review.gluster.org/7737 (glusterd/snapshot : Quorum check should not be made if we perform snapshot status command.) posted (#2) for review on master by Sachin Pandit (spandit)

Comment 3 Anand Avati 2014-05-12 10:11:10 UTC

REVIEW: http://review.gluster.org/7737 (glusterd/snapshot : Quorum check should not be made if we perform snapshot status command.) posted (#3) for review on master by Sachin Pandit (spandit)

Comment 4 Anand Avati 2014-05-12 10:11:30 UTC

REVIEW: http://review.gluster.org/7737 (glusterd/snapshot : Quorum check should not be made if we perform snapshot status command.) posted (#4) for review on master by Sachin Pandit (spandit)

Comment 5 Anand Avati 2014-05-14 05:34:08 UTC

COMMIT: http://review.gluster.org/7737 committed in master by Kaushal M (kaushal) 
------
commit 7d22fca1f5c9d792b148bae15e8d26a9c5d63efa
Author: Sachin Pandit <spandit>
Date:   Mon May 12 07:54:59 2014 +0530

    glusterd/snapshot : Quorum check should not be made if we
    perform snapshot status command.
    
    Problem : Snapshot status command used to fail as it used to
    hit the quorum check path.
    
    Solution : The condition checking where snapname is fetched
    based on the presence of snap_volume is moved inside create
    switch case.
    
    And also moved the chunk of code which does the actual
    quorum check to new function to make the code more
    readable.
    
    Change-Id: Idda2d7c576cdfab3a7d087bfa74bfa616372c20e
    BUG: 1096700
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/7737
    Reviewed-by: Rajesh Joseph <rjoseph>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Kaushal M <kaushal>

Comment 6 Niels de Vos 2014-09-22 12:40:17 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 7 Niels de Vos 2014-11-11 08:32:25 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users