Bug 1097223

Summary: Runtime quota reported as exceeded after hotplug cpu is blocked by the assigned quota
Product: Red Hat Enterprise Virtualization Manager Reporter: Ilanit Stein <istein>
Component: ovirt-engineAssignee: Gilad Chaplik <gchaplik>
Status: CLOSED CURRENTRELEASE QA Contact: Ilanit Stein <istein>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.4.0CC: dfediuck, gchaplik, gklein, iheim, istein, lpeer, mavital, rbalakri, Rhev-m-bugs, sherold, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: sla
Fixed In Version: org.ovirt.engine-root-3.5.0-14 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 17:09:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1156162    
Attachments:
Description Flags
edit quota screen shot
none
Datacenter Quota tab none

Description Ilanit Stein 2014-05-13 12:10:31 UTC
Description of problem:
For a data center, with quota definition of 1 single vCPU,
Try to hot plug a vm from 1 vCPU socket to 2.
The quota vCPU consumption is marked as exceeded.
 
In responce to the hot plug trial, the following events appear:
	
1. "Faild to hot set number of CPUS to VM vmtemp. Underlying error message: Cannot hot set cpus VM. Quota has no sufficient cluster resources."

** also there is a typo in Faild here.
	
2. "Cluster-Quota cpu1 limit exceeded and operation was blocked. Utilization: vcpu:100% , Requested: vcpu:100% - Please select a different quota or contact your administrator to extend the quota."

Version-Release number of selected component (if applicable):
av9

Expected result:
The quota should not me marked as exceeded such case.

Comment 1 Ilanit Stein 2014-05-13 12:16:55 UTC
Created attachment 895111 [details]
edit quota screen shot

Comment 2 Doron Fediuck 2014-05-14 04:28:16 UTC
(In reply to Ilanit Stein from comment #0)
> Description of problem:
> For a data center, with quota definition of 1 single vCPU,
> Try to hot plug a vm from 1 vCPU socket to 2.
> The quota vCPU consumption is marked as exceeded.

The above description is the correct definition for quota- limiting
the resources a user / group may consume.

- If you set a quota of 10 GiB, your disks' total cannot exceed 10 GiB.
- If you set a quota of 2 GiB RAM, the total RAM consumed by your VMs cannot exceed this number.
- The same applies for vCPUs. Regardless of hot or cold plug, you are not allowed to exceed this limitation.

The above is the design of quota limitations.
Please explain if your case aligns with the definitions. If not we should close
this issue as this is doing exactly what we want.

Comment 3 Ilanit Stein 2014-05-18 07:42:23 UTC
Created attachment 896751 [details]
Datacenter Quota tab

Comment 4 Ilanit Stein 2014-05-18 07:48:40 UTC
The problem described here is not that operation of increasing the number of cpus, above limit - this is of course, the expected behaviour.

It is about having the Quota marked as exceeded (in red), see attached 
'Datacenter Quota tab', though it was not exceeded.
The limit was 1 vCpu, and that was what defined.
The trial of increasing the vCPU from 1 to 2, had made quota marked as exceeded,
though, it didn't.

Comment 5 Doron Fediuck 2014-05-21 11:44:45 UTC
Just to clarify, so the issue here is that failure to hotplug cpu
due to quota limitations keeps the resource report as exceeding although
the hotplug action failed?

Comment 6 Ilanit Stein 2014-05-22 12:01:02 UTC
(In reply to Doron Fediuck from comment #5)
> Just to clarify, so the issue here is that failure to hotplug cpu
> due to quota limitations keeps the resource report as exceeding although
> the hotplug action failed?

Yes.

Comment 7 Gilad Chaplik 2014-05-22 18:15:04 UTC
(In reply to Ilanit Stein from comment #6)
> (In reply to Doron Fediuck from comment #5)
> > Just to clarify, so the issue here is that failure to hotplug cpu
> > due to quota limitations keeps the resource report as exceeding although
> > the hotplug action failed?
> 
> Yes.

and fix the typo :-P

Comment 8 Kobi 2014-05-26 15:37:56 UTC
The typo was fixed at: http://gerrit.ovirt.org/#/c/25175/

After testing it, and talking to Ilanit, I found that when hot plug fails, quota is acting as expected.
The only real issue Ilanit and I saw is that when quota is on 100% cpu it is reported as exceeded. I will fix that.

Comment 10 Eyal Edri 2014-10-07 07:13:06 UTC
this bug status was moved to MODIFIED before engine vt5 was built,
hence moving to on_qa, if this was mistake and the fix isn't in,
please contact rhev-integ

Comment 11 Ilanit Stein 2014-10-19 13:07:34 UTC
This bug cannot be verified, till this bug will be fixed: bug #1151827

Comment 12 Ilanit Stein 2014-10-20 08:36:37 UTC
Following bug #1151827 is fixed,
Verified on vt6.

For a vm with number of cpus = quota limit, Try to hot plug number of cpus, above quota limit fail (expected), and in quota tab it is still marked as 100%.

Comment 13 Eyal Edri 2015-02-17 17:09:15 UTC
rhev 3.5.0 was released. closing.