Bug 1098179
| Summary: | Fix spec rpmlint errors | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Kiril Nesenko <knesenko> |
| Component: | General | Assignee: | Yaniv Bronhaim <ybronhei> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavol Brilla <pbrilla> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 4.17.10 | CC: | bazulay, bugs, dfediuck, gklein, mgoldboi, oourfali, rbalakri, sbonazzo, srevivo, ybronhei |
| Target Milestone: | ovirt-4.1.0-beta | Flags: | rule-engine:
ovirt-4.1+
rule-engine: planning_ack+ rule-engine: devel_ack+ pstehlik: testing_ack+ |
| Target Release: | 4.18.9 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-15 14:53:06 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
The problem is that some of the python packages have modules that consist of src and others that are generated (.py.in) so that the package is not complete in src nor in build. I'd recommend reducing to minimum the amount of generated python files and if possible have an entirely generated package and the others entirely non-generated. *** Bug 1193112 has been marked as a duplicate of this bug. *** changing the focus of that bugzilla. checkdist errors are less critical then vdsm compatibility with fedora rules - currently rpmlint complains about the below error and those are easy to fix.
rpmlint ./vdsm.spec /var/lib/mock/epel-7-x86_64/result/vdsm-4.17.10-1.el7.src.rpm
./vdsm.spec:290: W: unversioned-explicit-obsoletes python-zombiereaper
./vdsm.spec:637: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/systemd-vdsmd
./vdsm.spec:638: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/system-preset/85-vdsmd.preset
./vdsm.spec:767: E: hardcoded-library-path in /usr/lib/systemd/systemd-vdsmd
./vdsm.spec:768: E: hardcoded-library-path in /usr/lib/systemd/system-preset/85-vdsmd.preset
vdsm.src:290: W: unversioned-explicit-obsoletes python-zombiereaper
vdsm.src:637: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/systemd-vdsmd
vdsm.src:638: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/system-preset/85-vdsmd.preset
vdsm.src:767: E: hardcoded-library-path in /usr/lib/systemd/systemd-vdsmd
vdsm.src:768: E: hardcoded-library-path in /usr/lib/systemd/system-preset/85-vdsmd.preset
1 packages and 1 specfiles checked; 8 errors, 2 warnings.
Latest (a6ff1cca1df4fc597d99377df43081a4169d01bc ):
[ykaul@ykaul vdsm]$ rpmlint ./vdsm.spec
./vdsm.spec:309: W: unversioned-explicit-obsoletes %{name}-python-zombiereaper
./vdsm.spec:688: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/systemd-vdsmd
./vdsm.spec:689: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/system-preset/85-vdsmd.preset
./vdsm.spec:823: E: hardcoded-library-path in /usr/lib/systemd/systemd-vdsmd
./vdsm.spec:824: E: hardcoded-library-path in /usr/lib/systemd/system-preset/85-vdsmd.preset
./vdsm.spec: W: invalid-url Source0: vdsm-4.17.999.tar.gz
0 packages and 1 specfiles checked; 4 errors, 2 warnings.
Do we wish to handle those for 4.0?
Yes. I plan to do it for 4.0. However, it doesn't effect vdsm build and installation in any way. Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA. oVirt 4.0 beta has been released, moving to RC milestone. $ rpmlint ./vdsm.spec ./vdsm.spec: W: invalid-url Source0: vdsm-4.19.4.tar.gz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. |
Description of problem: Trying to run make distcheck and getting the following error: make[3]: Leaving directory `/home/knesenko/git_repos/vdsm-3.3/vdsm-4.14.1/_build/vdsm' make[2]: Leaving directory `/home/knesenko/git_repos/vdsm-3.3/vdsm-4.14.1/_build/vdsm' Making all in vdsm-tool make[2]: Entering directory `/home/knesenko/git_repos/vdsm-3.3/vdsm-4.14.1/_build/vdsm-tool' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/home/knesenko/git_repos/vdsm-3.3/vdsm-4.14.1/_build/vdsm-tool' Making all in vdsm_api make[2]: Entering directory `/home/knesenko/git_repos/vdsm-3.3/vdsm-4.14.1/_build/vdsm_api' Generate vdsm-api.html PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=../../vdsm_api/../lib \ /usr/bin/python ../../vdsm_api/process-schema.py \ ../../vdsm_api/vdsmapi-schema.json ../../vdsm_api/vdsm-api.html Traceback (most recent call last): File "../../vdsm_api/process-schema.py", line 372, in <module> main() File "../../vdsm_api/process-schema.py", line 368, in main create_doc(symbols, output) File "../../vdsm_api/process-schema.py", line 292, in create_doc f = open(filename, 'w') IOError: [Errno 13] Permission denied: '../../vdsm_api/vdsm-api.html' make[2]: *** [vdsm-api.html] Error 1 make[2]: Leaving directory `/home/knesenko/git_repos/vdsm-3.3/vdsm-4.14.1/_build/vdsm_api' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/knesenko/git_repos/vdsm-3.3/vdsm-4.14.1/_build' make: *** [distcheck] Error 1 Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. ./autogen.sh; make dist; make distcheck 2. 3. Actual results: make distcheck fails Expected results: should work Additional info: