Bug 1098580

Hi Fabian,
  Do you think here should save the old/wrong values after hitting "save" on TUI?
  The similar bug on Kdump TUI: bug 957445

Thanks
Ying

Hey Einav,

as you are the expert. What do you say: If incorrect informations were put into fields (i.e. username and password) should they be cleared or not?

(In reply to Fabian Deutsch from comment #2)
> Hey Einav,
> 
> as you are the expert. What do you say: If incorrect informations were put
> into fields (i.e. username and password) should they be cleared or not?

Hi Fabian, 

I believe that the most common behavior is to keep all information in the fields, except password(s), if there are any. 
An incorrect value may be made correct only by changing/adding/removing a single character. having the user filling everything from scratch is a bad UX IMO.

[for passwords, the value is erased mostly due to security reasons, AFAIK. In addition, since password characters are usually shown as "*", the user will most likely enter it again from scratch, rather than fix the relevant character(s) so no UX problem in erasing it completely].

Ok, so should we keep all fields other than password?

It looks like, at present, we pull some of the information (URL, CA URL, proxy information) directly from the RHN/SAM config files, which will not succeed if registration fails.

Keeping the username is a definite yes.
What about the rest?

(In reply to Ryan Barry from comment #4)
> Ok, so should we keep all fields other than password?
> 
> It looks like, at present, we pull some of the information (URL, CA URL,
> proxy information) directly from the RHN/SAM config files, which will not
> succeed if registration fails.
> 
> Keeping the username is a definite yes.
> What about the rest?

I am not familiar with the exact RHEV-H registration process, fields involved, etc. 
The BZ reporter mentioned "Login", "Password" & "Profile Name". So all of these other than "Password" should be kept; again, the reason is that the user may need to make only a very small change to the incorrect input in order to make it correct. If there are additional non-password fields - their values should be kept as well. 
if there are fields that it makes sense to clear, e.g. fields that are supposed to be filled automatically by pulling information from RHN/SAM config files (rather than be filled manually by the user), and this information-pulling has due to a failed registration process - then obviously these fields will have to be empty.

Test Version:
rhev-hypervisor7-7.0-20150114.0
ovirt-node-3.2.1-4.el7.noarch

rhev-hypervisor6-6.6-20150114.0
ovirt-node-3.2.1-4.el6.noarch

Test step:
1. Go to TUI or RHEVH / RHN Registration
2. Fill Login & incorrect Password & Profile Name, keep RHN, hit Save button
3. On next screen hit Close button

Test result:
1. It keeps the information (even wrong) except the password in TUI.

So this issue is fixed in rhev-hypervisor6-6.6-20150114.0 and rhev-hypervisor7-7.0-20150114.0. Change the status from ON_QA to Verified.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2015-0160.html