Bug 1098778
| Summary: | Review Request: perl-Redis - Perl binding for Redis database | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Dick <ddick> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gwync, i, package-review, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Redis-1.974-1.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-27 21:50:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1084945 | ||
| Bug Blocks: | |||
|
Description
David Dick
2014-05-18 12:54:04 UTC
koji builds at rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=6860777 el6 at http://koji.fedoraproject.org/koji/taskinfo?taskID=6860771 It looks pretty good, however! I don't see `utf8' used anywhere but in the POD of your patch. I'd say you can drop that BR entirely. Also, I think Time::HiRes is pulled in by the documentation (which shouldn't be happening and may change in the near future) rather than the actual code. I think it'd be safer if you required it explicitly. Consider doing those changes before pushing. I'm approving the package now. Happy to make both those changes Petr. I've re-built and pushed it out again. Thanks again! New Package SCM Request ======================= Package Name: perl-Redis Short Description: Perl binding for Redis database Upstream URL: http://search.cpan.org/dist/Redis/ Owners: ddick Branches: f20 el6 epel7 InitialCC: perl-sig Git done (by process-git-requests). perl-Redis-1.974-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Redis-1.974-1.fc20 perl-Redis-1.974-1.fc20 has been pushed to the Fedora 20 testing repository. perl-Redis-1.974-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Redis-1.974-1.el6 perl-Redis-1.974-1.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: perl-Redis New Branches: f19 Owners: ddick InitialCC: perl-sig Git done (by process-git-requests). perl-Redis-1.974-1.el6 has been pushed to the Fedora EPEL 6 stable repository. perl-Redis-1.974-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Redis-1.974-1.fc19 perl-Redis-1.974-1.fc19 has been pushed to the Fedora 19 stable repository. |