Bug 1099101

Description of problem:

Recent addition to urlgrabber is broken (quite obviously):
http://yum.baseurl.org/gitweb?p=urlgrabber.git;a=commit;h=bf0a0be71373dec515bbb54e0613a3b9b0c00b04

I strongly suggest it's reverted.

55 and 56 errors are not keyboard interruptions and should not be propagated as such. The bug reference is broken (a private bug), I presume it was done to combat yum ctrl+c handling. It was not done correctly -- curl should either be told not to hook INT signal or use a different error to signal the condition.

With the patch applied, with repository not responding yum thinks user aborted it:

[root@lr-death-to-all ~]# yum -v -d 8 install perl-LWP-Protocol-https-6.04-4.el7.noarch
Not loading "rhnplugin" plugin, as it is disabled
Loading "fastestmirror" plugin
Loading "priorities" plugin
Loading "product-id" plugin
Loading "subscription-manager" plugin
Loading "versionlock" plugin
Updating Subscription Management repositories.
Unable to read consumer identity
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Config time: 0.090
Yum version: 3.4.3
rpmdb time: 0.000
Setting up Package Sacks

 Current download cancelled, interrupt (ctrl-c) again within two seconds
to exit.

This is very confusing and given it aborts yum even with skip_if_unavailable=1, it makes it possible to lock out package management, making it impossible to address an issue with a package update.

Version-Release number of selected component (if applicable):

python-urlgrabber-3.10-4.el7.noarch

How reproducible:

Always

Steps to Reproduce:
1. Start a server that terminates connection immediately after accepting a client
2. Add it as a repository baseurl to yum
3. Run yum

Additional info:

strace:

2334  sendto(10, "GET /gdc-dev-us-yum/7/master/repodata/repomd.xml HTTP/1.1\r\nUser-Agent: urlgrabber/3.10 yum/3.4.3\r\nHost: localhost:3333\r\nAccept: */*\r\n\r\n", 135, MSG_NOSIGNAL, NULL, 0) = 135
2334  poll([{fd=10, events=POLLIN|POLLPRI|POLLRDNORM|POLLRDBAND}], 1, 0) = 0 (Timeout)
2334  poll([{fd=10, events=POLLIN}], 1, 1000) = 1 ([{fd=10, revents=POLLIN|POLLERR|POLLHUP}])
2334  poll([{fd=10, events=POLLIN|POLLPRI|POLLRDNORM|POLLRDBAND}], 1, 0) = 1 ([{fd=10, revents=POLLIN|POLLRDNORM|POLLERR|POLLHUP}])
2334  recvfrom(10, 0xf35f80, 16384, 0, 0, 0) = -1 ECONNRESET (Connection reset by peer)
2334  close(10)                         = 0

^^^ this is where the connection terminates