Bug 1099473
| Summary: | Review Request: python-django-angular - Classes and utility functions to integrate AngularJS with Django | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Runge <mrunge> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jeffschroeder, karlthered, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-01-20 09:52:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1041968 | ||
|
Description
Matthias Runge
2014-05-20 12:02:20 UTC
Note that I'm not an official package reviewer yet, so this is only to help a real reviewer. Questions / Suggestions ======================= 1. This is a django reusable app, shouldn't it "Require: Django"? 2. In %install, you remove the egg-info directory, but it is still in the package: [jeff@omniscience SPECS] (master)$ rpm -qlp ../RPMS/python-django-angular-0.7.1-1.fc20.noarch.rpm | grep \.egg-info /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info/PKG-INFO /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info/SOURCES.txt /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info/dependency_links.txt /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info/requires.txt /usr/lib/python2.7/site-packages/django_angular-0.7.1-py2.7.egg-info/top_level.txt Also, fedora packaging python policy is explicit on keeping the egg-info directory: http://fedoraproject.org/wiki/Packaging:Python#Files_to_include You then include it explicitly in %files, why? RPMlint output ============== Looks good to me [jeff@omniscience SPECS] (master)$ rpmlint python-django-angular.spec ../SRPMS/python-django-angular-0.7.1-1.fc20.src.rpm ../RPMS/python-django-angular-0.7.1-1.fc20.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Other than those 2 small things, this looks good to me. Thank you for your quick review. You're right, this depends on Django. upstream distributed eggs have to be removed before build process, to prevent those get re-distributed. Eggs generated during build process (as in this case), are required to be included in the final rpm. http://fedoraproject.org/wiki/Packaging:Python#Files_to_include SPEC: http://www.matthias-runge.de/fedora/python-django-angular.spec SRPM: http://www.matthias-runge.de/fedora/python-django-angular-0.7.1-2.fc20.src.rpm Looks good to me, but unfortunately, I can't do much from here. Is it required for Horizon ? It also needs to be updated to 0.7.5 *** This bug has been marked as a duplicate of bug 1182533 *** |