Bug 1099683

Summary: Silent error from call to realpath in features/changelog/lib/src/gf-history-changelog.c
Product: [Community] GlusterFS Reporter: Keith Schincke <kschinck>
Component: changelogAssignee: Venky Shankar <vshankar>
Status: CLOSED EOL QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: 3.5.0CC: bugs, smohan
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-17 16:24:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
realpath() check patch. none

Description Keith Schincke 2014-05-21 01:27:31 UTC 
Created attachment 897778 [details]
realpath() check patch.

Description of problem:
The call to realpath() can fail but no useful error message is logged. The gf_history_changelog_done() function will return with a -1 return code. 

https://github.com/gluster/glusterfs/blame/master/xlators/features/changelog/lib/src/gf-history-changelog.c#L64

Patch attached.

Version-Release number of selected component (if applicable):
3.5

How reproducible:
100% 

Steps to Reproduce:
1. view code
2.
3.

Actual results:
No useful error message

Expected results:
Useful errror reporting. 

Additional info:
Comment 1 Anand Avati 2014-06-19 15:35:27 UTC 
REVIEW: http://review.gluster.org/8122 (Add useful message for silent error: bug 1099683) posted (#1) for review on master by Keith Schincke (kschinck)
Comment 2 Mike McCune 2016-03-28 23:45:25 UTC 
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions
Comment 3 Niels de Vos 2016-06-17 16:24:04 UTC 
This bug is getting closed because the 3.5 is marked End-Of-Life. There will be no further updates to this version. Please open a new bug against a version that still receives bugfixes if you are still facing this issue in a more current release.