Bug 1099981

Summary: syncing repo with typo in URL creates lock
Product: Red Hat Satellite Reporter: Jan Hutař <jhutar>
Component: WebUIAssignee: Ivan Necas <inecas>
Status: CLOSED CURRENTRELEASE QA Contact: Ales Dujicek <adujicek>
Severity: high Docs Contact:
Priority: unspecified    
Version: NightlyCC: adujicek, bbuckingham, jmontleo
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/6072
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-02 14:06:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jan Hutař 2014-05-21 17:29:43 UTC
Description of problem:
Syncing repo with typo in URL creates lock.


Version-Release number of selected component (if applicable):
Satellite-6.0.3-RHEL-6-20140521.0


How reproducible:
always


Steps to Reproduce:
1. Create new product in webUI:
   Content -> Products -> [+ New Product]
     Name: ISEProduct
2. Create new repository in the product:
   Content -> Products -> ISEProduct -> [Create Repository]
     Name: ISERepository
     Type: yum
     URL: http://www.redhat.com/notExistingRepo
3. Sync it (using Content -> Sync Status ... do not trigger this, just fails,
   but I do not see the lock - strange (!))
   Content -> Products -> ISEProduct -> ISERepository -> [Sync Now]
   Also you can initialize sync using hammer.


Actual results:
Looks like some locks are left around.


Expected results:
Should fail without locks around or something.


Additional info:
To clean this, you have to release the lock:
  Monitor -> Tasks -> <your_failed_task> -> [Force Stop] -> [Force Stop]

Comment 2 Ivan Necas 2014-05-28 08:59:41 UTC
I'm working on better handling of the error states in Dynflow as part of https://bugzilla.redhat.com/show_bug.cgi?id=1093124 so that at the end, it should finish the task with warnings instead of pausing in this case

Comment 3 Ivan Necas 2014-06-04 21:56:39 UTC
Created redmine issue http://projects.theforeman.org/issues/6072 from this bug

Comment 4 Ivan Necas 2014-06-10 11:35:20 UTC
Note for release nanny: depends on dynflow-0.7.0 and foreman-tasks-0.6.0

The changed in Katello were made in https://github.com/Katello/katello/pull/4219

Comment 7 Ales Dujicek 2014-06-16 13:04:35 UTC
created repository with wrong URL and synchronization task finished -> Verified.

Satellite-6.0.3-RHEL-6-20140612.1

Comment 8 Bryan Kearney 2014-07-02 14:06:00 UTC
This was delivered with 6.0.3, which is the Satellite 6 Beta.