Bug 1100139

Summary:	Non existent entities in content spec metadata causes builds to fail
Product:	[Community] PressGang CCMS	Reporter:	Lee Newson <lnewson>
Component:	CCMS-Core	Assignee:	Lee Newson <lnewson>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.5	CC:	mcaspers
Target Milestone:	---
Target Release:	1.6
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-05-28 21:56:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lee Newson 2014-05-22 06:01:58 UTC

If you have something like:

Product = &NON_EXISTANT;
Copyright Holder = &NON_EXISTANT;

then builds will fail when trying to build with publican/jdocbook. This should be caught by the content spec validator when saving.

Comment 1 Lee Newson 2014-05-22 07:23:43 UTC

Fixed in 1.6-SNAPSHOT build 201405221722

The following metadata is now checked for invalid entities and will produce an error when one is found (since these are the only ones that can make use of it in the output):

Title
Product
Subtitle
Abstract
Version
Copyright Holder
Copyright Year
Edition
Pubsnumber

Comment 2 Lee Newson 2014-05-22 08:43:37 UTC

Actually this should also check for invalid XML, as it probably won't fail the build but it will output unexpected results.

Comment 3 Lee Newson 2014-05-22 10:05:27 UTC

Fixed in 1.6-SNAPSHOT build 201405222004

The following elements are now fully validated to catch any invalid XML, which also includes entities:

Title
Product
Subtitle
Copyright Holder
Abstract (this was already done, so the logic was reused for the other elements)

Also note that the following were excluded since they are limited to certain regex values and therefore can't be invalid:

Copyright Year
Version
Edition
Pubsnumber

Comment 4 Matthew Casperson 2014-05-22 22:53:18 UTC

Confirmed that missing entities assigned to Title, Product, Subtitle, Copyright Holder and Abstract generate the appropriate errors.

Also tried to assign entities to Copyright Year, Version, Edition and Pubsnumber and got appropriate errors.