Bug 1101474

Summary:	CVE-2014-0246 sos: md5 hash of GRUB password collected when running sosreport [fedora-all]
Product:	[Fedora] Fedora	Reporter:	Murray McAllister <mmcallis>
Component:	sos	Assignee:	Bryn M. Reeves <bmr>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	20	CC:	bmr, kroberts, vdanen
Target Milestone:	---	Keywords:	Security, SecurityTracking
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	sos-3.1-1.fc20	Doc Type:	Release Note
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-27 02:21:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1101393

Description Murray McAllister 2014-05-27 09:15:55 UTC

This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of Fedora.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When creating a Bodhi update request, use the bodhi submission link noted
in the next comment(s).  This will include the bug IDs of this tracking
bug as well as the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
Bodhi notes field when available.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

[bug automatically created by: add-tracking-bugs]

Comment 1 Murray McAllister 2014-05-27 09:16:01 UTC

Use the following update submission link to create the Bodhi request for
this issue as it contains the top-level parent bug(s) as well as this
tracking bug.  This will ensure that all associated bugs get updated when
new packages are pushed to stable.

IMPORTANT: ensure that the "Close bugs when update is stable" option
remains checked.

Bodhi update submission link:
https://admin.fedoraproject.org/updates/new/?type_=security&bugs=1101393,1101474

Comment 2 Bryn M. Reeves 2014-05-30 13:51:16 UTC

Note that this does not actually affect F20 as described since Fedora switched to Grub2 in F16 (which uses a different mechanism for password protecting the bootloader).

I'm working on fixes for both grub versions for sos-2.x and 3.x.

Comment 3 Bryn M. Reeves 2014-06-02 14:32:30 UTC

The grub1 case is now fixed upstream:

commit 6501013bb780161e941f5e078a6ed7052f670a51
Author: Bryn M. Reeves <bmr>
Date:   Mon Jun 2 15:27:10 2014 +0100

    Make sure grub password regex handles all cases


commit 23182c4f13fbadc9b7c2ab75c1ca249d5ba987d1
Author: Bryn M. Reeves <bmr>
Date:   Mon Jun 2 14:55:03 2014 +0100

    Elide bootloader password in grub plugin

I'm working on equivalent changes for grub2 now (there's not much point pushing an update to Fedora releases until this is done); it's a bit more complex as the notion of passwords and users in grub2 is a lot more elaborate than previous releases.

Comment 4 Bryn M. Reeves 2014-06-03 18:29:31 UTC

Grub2 bits are now upstream:

commit d335f4f09d033008cb6485d2cd8ca371a974d700
Author: Bryn M. Reeves <bmr>
Date:   Tue Jun 3 19:23:46 2014 +0100

    Elide passwords in grub2 plugin
    
    Remove both plaintext and pbkdf2 passwords from grub configuration
    files and command output. Since grub does not mandate any
    particular location for its authentication data we have to apply
    these liberaly (to all grub*.cfg as well as to all /etc/grub.d
    fragments and the output of grub2-mkconfig).
    
    Signed-off-by: Bryn M. Reeves <bmr>

Unfortunately this ends up being quite complex; grub2 has a notion of multiple users (with optional plaintext or pbkdf2 hashed passwords for each user) and these can be configured just about anywhere: in grub.cfg directly (manual edit), in an /etc/grub.d fragment or hacked into grub2-mkconfig itself. The plugin now applies the substitution to all grub*.cfg files as well as everything in /etc/grub.d and the command output.

I've tested several different configurations here and this is passing all my tests but I'd appreciate more feedback from users with password-protected grub2 configurations.

Comment 5 Bryn M. Reeves 2014-06-17 22:52:15 UTC

Fixed in rawhide with update to sos-3.2-0.1.a.fc21:

  http://pkgs.fedoraproject.org/cgit/sos.git/log/

Fixed in f20 with rebase to sos-3.1 and backport of the grub patches.

  http://pkgs.fedoraproject.org/cgit/sos.git/commit/?h=f20

Comment 6 Fedora Update System 2014-06-17 23:10:59 UTC

sos-3.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/sos-3.1-1.fc20

Comment 7 Fedora Update System 2014-06-18 22:22:25 UTC

Package sos-3.1-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing sos-3.1-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-7479/sos-3.1-1.fc20
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2014-06-27 02:21:03 UTC

sos-3.1-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.