Bug 1101586

Summary:	activation_keys.update updates also not present parameters
Product:	Red Hat Satellite	Reporter:	Tomas Lestach <tlestach>
Component:	API	Assignee:	Walden Raines <walden>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Tazim Kolhar <tkolhar>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.0.3	CC:	bkearney, cwelton, jmontleo, tkolhar, walden
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
URL:	http://projects.theforeman.org/issues/6514
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-09-11 12:29:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Lestach 2014-05-27 14:51:28 UTC

Description of problem:
activation_keys.update API call updates also activation key attributes not sent via the call

Version-Release number of selected component (if applicable):
Satellite-6.0.3-RHEL-6-20140523.0-Satellite-x86_64

How reproducible:
always

Steps to Reproduce:
1. create an activation key with 'usage_limit' set to an integer value
2. call activation_keys.update API to set only the 'content_view_id' for the activation key

Actual results:
note that the 'usage_limit' was re-set to 'unlimited'

Expected results:
not present parameters in the update API call shall be preserved

Comment 1 RHEL Program Management 2014-05-27 14:54:03 UTC

Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Tomáš Kašpárek 2014-05-28 13:09:19 UTC

created pull request: https://github.com/Katello/katello/pull/4167

Comment 4 Dustin Tsang 2014-06-30 22:13:29 UTC

PR looks good. PR just needs to get past CI before it can be merged. 
For CI to run, can you make your group membership public on this page:
https://github.com/orgs/Katello/members?page=2 ?

Comment 5 Tomáš Kašpárek 2014-07-01 06:53:17 UTC

I am already public member of Katello, however I was not public member at the time I was creating the PR.

Comment 6 Eric Helms 2014-07-07 19:01:42 UTC

Created redmine issue http://projects.theforeman.org/issues/6514 from this bug

Comment 7 Walden Raines 2014-07-08 17:27:56 UTC

PR: https://github.com/Katello/katello/pull/4360

Comment 8 Bryan Kearney 2014-07-08 20:02:04 UTC

Moving to POST since upstream bug http://projects.theforeman.org/issues/6514 has been closed
-------------
Walden Raines
This is fixed with https://github.com/Katello/katello/pull/4360
-------------
Walden Raines
Applied in changeset commit:katello|607f4e7fdeefa10091b24a8a06fd2a45939c6038.

Comment 10 Tazim Kolhar 2014-08-18 09:33:36 UTC

VERIFIED

usage-limit remains intact with set integer value

Comment 11 Bryan Kearney 2014-09-11 12:29:50 UTC

This was delivered with Satellite 6.0 which was released on 10 September 2014.