Bug 1102617

Summary:	Prevent deletion of admin group
Product:	[Retired] Beaker	Reporter:	Amit Saha <asaha>
Component:	general	Assignee:	matt jia <mjia>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	0.16	CC:	aigao, alemay, asaha, dcallagh, dowang, ebaak, mjia
Target Milestone:	19.1	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-12-17 08:40:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Amit Saha 2014-05-29 10:18:44 UTC

Description of problem:

A member of the "admin" group can remove the "admin" group. This doesn't sound right.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Cannot delete the admin group.


Additional info:

Comment 2 Nick Coghlan 2014-05-30 05:59:39 UTC

Just took a look at the code, and indeed, there is no check against "is_protected_group()" for group removal - so the "queue_admin" and "lab_controller" groups can also be removed.

Group removal should be moved to a helper method on bkr.server.model.identity.Group and protected names guarded (in a similar setup to their existing protection against name changes)

Comment 4 matt jia 2014-11-12 23:55:48 UTC

On Gerrit:

http://gerrit.beaker-project.org/#/c/3477/

Cheers, Matt Jia

Comment 7 Dan Callaghan 2014-12-17 08:40:23 UTC

Beaker 19.1 is released.