Bug 1102687

Summary:	[engine-backend] [iSCSI multipath] Internal engine error when vdsm fails to connect to storage server with IscsiNodeError
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	rhev-integ
Component:	ovirt-engine	Assignee:	Maor <mlipchuk>
Status:	CLOSED UPSTREAM	QA Contact:	Elad <ebenahar>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.4.0	CC:	acanan, acathrow, amureini, gklein, iheim, lpeer, mlipchuk, Rhev-m-bugs, scohen, tpoitras, yeylon
Target Milestone:	---	Keywords:	ZStream
Target Release:	3.4.1
Hardware:	x86_64
OS:	Unspecified
Whiteboard:	storage
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Previously when configuring an iSCSI multipath bond, if vdsm was unable to connect to the storage server, then it caused an internal engine error. Now, calling ConnectStorageServer catches the exception when attempting to connect all the hosts; if one of them fails, then vdsm will try to connect to other hosts.	Story Points:	---
Clone Of:	1094023	Environment:
Last Closed:	2014-07-27 12:08:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1094023
Bug Blocks:

Comment 2 Aharon Canan 2014-06-30 14:14:09 UTC

Maor - 
Do we have clear flow for verification?
We can't reproduce it and want to be sure we are going throw the code changes when we are verifying it.

Comment 3 Maor 2014-06-30 14:25:53 UTC

IINM VDSM should still throw an exception as before:
Thread-1846::ERROR::2014-05-04 15:40:44,971::hsm::2379::Storage.HSM::(connectStorageServer) Could not connect to storageServer
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/hsm.py", line 2376, in connectStorageServer
    conObj.connect()
  File "/usr/share/vdsm/storage/storageServer.py", line 359, in connect
    iscsi.addIscsiNode(self._iface, self._target, self._cred)
  File "/usr/share/vdsm/storage/iscsi.py", line 166, in addIscsiNode
    iscsiadm.node_login(iface.name, portalStr, targetName)
  File "/usr/share/vdsm/storage/iscsiadm.py", line 295, in node_login
    raise IscsiNodeError(rc, out, err)
IscsiNodeError: (8, ['Logging in to [iface: eth0.1, target: 

All that needs to be check is that we get the following message in the log: "Could not connect Host {0} - {1} to Iscsi Storage Server. T
he exception is: {2}"

That way, you should know that we got an exception, and engine will still finish with success

Comment 4 Aharon Canan 2014-07-27 12:08:20 UTC

After several tries, we couldn't hit the relevant flow - Can't verify for sure.

Following my email with DEV/PM - closing as works for me.

Comment 5 Elad 2014-08-10 15:08:29 UTC

Since this bug was fixed but I'm unable to get the iscsiNodeError in vdsm as part of network replacement inside the iscsi bond, which was trigger the internal engine error, I'm closing this bug as UPSTREAM

Comment 6 Elad 2014-08-10 15:09:17 UTC

Since this bug was fixed but I'm unable to get the iscsiNodeError in vdsm as part of network replacement inside the iscsi bond, which was trigger the internal engine error, I'm closing this bug as UPSTREAM