Bug 1102797

Summary: can't build dhcp due to systemtap
Product: [Fedora] Fedora Reporter: Jiri Popelka <jpopelka>
Component: systemtapAssignee: Frank Ch. Eigler <fche>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: rawhideCC: brolley, dsmith, fche, jistone, lberk, mjw, nathans, scox, wcohen
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-09-08 15:46:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
conforming version of dtrace input file none

Description Jiri Popelka 2014-05-29 14:51:07 UTC
Description of problem:

Building dhcp in rawhide fails [1] on:

dtrace -C -h -s probes.d -o probes.h
provider dhcpd {
^
Expected end of text (at char 130), (line:7, col:1)

I've no idea what can be wrong.
The systemtap patch I use is [2].

Version-Release number of selected component (if applicable):
systemtap-sdt-devel-2.6-0.69.g27ce133c59da.fc21.x86_64

How reproducible:
always

Additional info:
last successful build [3] was with
systemtap-sdt-devel-2.6-0.11.gbe329745a929.fc21.x86_64


[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=6907581
[2] http://pkgs.fedoraproject.org/cgit/dhcp.git/tree/dhcp-systemtap.patch
[3] https://kojipkgs.fedoraproject.org//packages/dhcp/4.3.0/10.fc21/data/logs/x86_64/

Comment 1 Stan Cox 2014-05-29 17:09:13 UTC
dtrace previously was using regular expression recognition but there are limitations with that approach, so now it uses pyparsing by default.  The parser was assuming probe names were C syntax (did not begin with a digit) and probe definitions ended with a ';'  I will look into relaxing these.

Comment 2 Stan Cox 2014-05-29 19:00:01 UTC
Created attachment 900491 [details]
conforming version of dtrace input file

Here is a version of the dtrace input file that conforms to:
 - probe statements end in ';'
 - probe names conform to C variable syntax

Comment 3 Stan Cox 2014-05-29 20:08:27 UTC
commit: 5dd56b4fa
Relax static-probes.d input file syntax.

Comment 4 Jiri Popelka 2014-05-30 09:44:59 UTC
(In reply to Stan Cox from comment #2)
> Here is a version of the dtrace input file that conforms to:
>  - probe statements end in ';'
>  - probe names conform to C variable syntax

Builds ok now, thank you.

Comment 5 Frank Ch. Eigler 2014-09-08 15:46:43 UTC
corrections in .d input file were sufficient