Bug 1102942 (php-phpoffice-phpexcel)
| Summary: | Review Request: php-phpoffice-phpexcel - A pure PHP library for reading and writing spreadsheet files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | amessina, fedora, package-review, private, rcollet, tcallawa, Tr | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-10-23 16:18:52 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1102941 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2014-05-29 21:21:43 UTC
The PHPExcel / Shared / OLE part is obviously same code than pear/ole which is available in Fedora (from pear) and also alive in packagist and github https://github.com/pear/OLE Can you please try to see the dif between the 2 versions and ask upstream why they don't simply use upstream version with a composer depedency ? Also, which changes in phpexcel are needed which can't be merged in ole. This will also fix the license issue. Marking this review as NotReady until I can answer the question in comment #1 -- see https://github.com/PHPOffice/PHPExcel/issues/407 Response from upstream regarding OLE: https://github.com/PHPOffice/PHPExcel/issues/407#issuecomment-49647361 Can you please open a FPC ticket for bundling exception ? Seems really a fork of a dead project, so should be ok. I think that "Excel" is trademark. http://tsdr.uspto.gov/#caseNumber=78400429&caseType=SERIAL_NO&searchType=statusSearch http://tsdr.uspto.gov/#caseNumber=85467589&caseType=SERIAL_NO&searchType=statusSearch I suggest that rename software name. Blocking FE-Legal. The use of the trademark "excel" is nominative here, since we are using it in a minimal way to describe this applications support and manipulation of the excel file format. Thus, the use is considered fair use and appropriate. Lifting FE-Legal. According to https://fedorahosted.org/fesco/ticket/1483 the bundling is no more an issue. So check if the package need to be refreshed and add the required bundled(pear/ole) siwinski's scratch build of php-phpoffice-phpexcel-1.8.1-1.fc22.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11375778 (In reply to Remi Collet from comment #8) > According to https://fedorahosted.org/fesco/ticket/1483 the bundling is no > more an issue. > > So check if the package need to be refreshed and add the required > > bundled(pear/ole) I used "bundled(php-pear-OLE)" instead to follow "New names must follow the rules one would use were the library to be packaged separately" -- https://lists.fedoraproject.org/pipermail/packaging/2015-October/011051.html Spec URL: https://raw.githubusercontent.com/siwinski/rpms/81dd3f8cdeb0754a591811a001ee25d325ce315e/php-phpoffice-phpexcel/php-phpoffice-phpexcel.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-phpoffice-phpexcel-1.8.1-1.fc22.src.rpm Created attachment 1081803 [details]
phpci.log
phpCompatInfo version 4.5.1 DB built Oct 11 2015 19:05:51 CEST static analyze results
Created attachment 1081804 [details]
review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Everything ok. No Blocker === APPROVED === THANKS for the review!!! New Package SCM Request ======================= Package Name: php-phpoffice-phpexcel Short Description: A pure PHP library for reading and writing spreadsheet files Upstream URL: https://github.com/PHPOffice/PHPExcel Owners: siwinski Branches: f21 f22 f23 el6 epel7 InitialCC: This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests. SCM request submitted via pkgdb php-phpoffice-phpexcel-1.8.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-eebe3d6719 php-phpoffice-phpexcel-1.8.1-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-fc29c2ddd8 php-phpoffice-phpexcel-1.8.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-1641d69ac7 php-phpoffice-phpexcel-1.8.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8cfe865957 php-phpoffice-phpexcel-1.8.1-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-5e502f2b93 php-phpoffice-phpexcel-1.8.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-phpoffice-phpexcel' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-1641d69ac7 php-phpoffice-phpexcel-1.8.1-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-phpoffice-phpexcel' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-5e502f2b93 php-phpoffice-phpexcel-1.8.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-phpoffice-phpexcel' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-eebe3d6719 php-phpoffice-phpexcel-1.8.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update php-phpoffice-phpexcel' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-fc29c2ddd8 php-phpoffice-phpexcel-1.8.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update php-phpoffice-phpexcel' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8cfe865957 php-phpoffice-phpexcel-1.8.1-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. php-phpoffice-phpexcel-1.8.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. php-phpoffice-phpexcel-1.8.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. php-phpoffice-phpexcel-1.8.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. php-phpoffice-phpexcel-1.8.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |