Bug 1103342

Summary:	Capsule happily syncs even when no lifecycle-environments are attached.
Product:	Red Hat Satellite	Reporter:	Justin Sherrill <jsherril>
Component:	API	Assignee:	Brad Buckingham <bbuckingham>
Status:	CLOSED WONTFIX	QA Contact:	Katello QA List <katello-qa-list>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	6.0.3	CC:	bbuckingham, bkearney, cwelton, omaciel
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
URL:	http://projects.theforeman.org/issues/6673
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-08-20 00:16:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Justin Sherrill 2014-05-30 19:20:07 UTC

Description of problem:


Doing a :

hammer capsule synchronize 

will happily sync your capsule even if nothing is attached to sync.  It should throw an error if there is nothing to sync explaining that lifecycle environments need to be attached.

Comment 2 Brad Buckingham 2014-07-17 17:09:18 UTC

Created redmine issue http://projects.theforeman.org/issues/6673 from this bug

Comment 3 Brad Buckingham 2014-07-28 15:56:09 UTC

Proposed fix in Katello PR: 
   https://github.com/Katello/katello/pull/4489

Comment 4 Brad Buckingham 2014-07-31 18:19:56 UTC

Based on feedback on the PR in comment #3, we did not merge the proposed changes.  It appears that there is a valid use case for performing a sync on a capsule that has no lifecycle environments attached.  For example, it would help to clear a capsule if for some reason the server didn't automatically initiate the cleanup when the lifecycle environments are removed.

For this BZ, it might be useful to return a 'warning' to the user; however, given that we do not do anything like that today for other APIs, we are going to move this bug to a future release.

Comment 5 Bryan Kearney 2014-08-20 00:16:41 UTC

I am closing this based on usptream discussions at https://github.com/Katello/katello/pull/4489. If you disagree, please reopen with your reasoning.