Bug 1104721

Summary: perl-CGI-Application-Plugin-RateLimit-1.0-10.fc21 FTBS: t/03complex.t fails randomly
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: perl-CGI-Application-Plugin-RateLimitAssignee: Petr Pisar <ppisar>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: emmanuel, perl-devel
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-CGI-Application-Plugin-RateLimit-1.0-13.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-21 15:29:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2014-06-04 14:38:35 UTC
perl-CGI-Application-Plugin-RateLimit-1.0-10.fc21 fails to build sometimes due test:

#   Failed test at t/03complex.t line 121.
#                   'Content-Type: text/html; charset=ISO-8859-1
# 
# LOGIN'
#     doesn't match '(?^:TOO FAST FOR failed_login)'
# Looks like you failed 1 test of 15.
t/03complex.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed

This happens under heavy load and it's caused by a race in the tests which do not check the elapsed test time is within limits set into tested application.

Comment 1 Petr Pisar 2014-06-24 08:21:27 UTC
It still fails sometimes. Probably there is another race.

Comment 2 Petr Pisar 2014-07-21 12:09:07 UTC
It still sometimes fails:

#   Failed test at t/03complex.t line 112.
#                   'Content-Type: text/html; charset=ISO-8859-1
# 
# ONE'
#     doesn't match '(?^:TOO FAST)'
#   Failed test at t/03complex.t line 131.
#                   'Content-Type: text/html; charset=ISO-8859-1
# 
# LOGIN'
#     doesn't match '(?^:TOO FAST FOR failed_login)'
# Looks like you failed 2 tests of 15.
t/03complex.t .. 
Dubious, test returned 2 (wstat 512, 0x200)
Failed

Comment 3 Petr Pisar 2014-07-21 15:29:22 UTC
Fixed as perl-CGI-Application-Plugin-RateLimit-1.0-13.fc21 in F21.