Bug 1105415

Summary: [SNAPSHOT]: Auto-delete should be user configurable
Product: [Community] GlusterFS Reporter: rjoseph
Component: coreAssignee: Sachin Pandit <spandit>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, gluster-bugs, nsathyan, spandit
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.6.0beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1107523 (view as bug list) Environment:
Last Closed: 2014-11-11 08:34:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1107523    

Description rjoseph 2014-06-06 04:58:58 UTC
Description of problem:

Auto-delete option should be user configurable. 

Auto-delete should happen only when this feature is enabled. If this feature is disabled then upon hitting the snapshot soft-limit we should show a warning to the user.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Sachin Pandit 2014-06-10 11:31:37 UTC
The patch which fixes this can be found in http://review.gluster.org/#/c/8017/

Comment 2 Anand Avati 2014-06-10 12:02:00 UTC
REVIEW: http://review.gluster.org/8017 (glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.) posted (#3) for review on master by Sachin Pandit (spandit)

Comment 3 Anand Avati 2014-06-10 19:06:00 UTC
REVIEW: http://review.gluster.org/8017 (glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.) posted (#4) for review on master by Sachin Pandit (spandit)

Comment 4 Anand Avati 2014-06-11 07:25:49 UTC
REVIEW: http://review.gluster.org/8017 (glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.) posted (#5) for review on master by Sachin Pandit (spandit)

Comment 5 Anand Avati 2014-06-11 07:42:59 UTC
REVIEW: http://review.gluster.org/8017 (glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.) posted (#6) for review on master by Sachin Pandit (spandit)

Comment 6 Anand Avati 2014-06-11 11:40:29 UTC
REVIEW: http://review.gluster.org/8017 (glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.) posted (#7) for review on master by Sachin Pandit (spandit)

Comment 7 Anand Avati 2014-06-11 11:58:07 UTC
REVIEW: http://review.gluster.org/8017 (glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.) posted (#8) for review on master by Sachin Pandit (spandit)

Comment 8 Anand Avati 2014-06-12 05:57:49 UTC
REVIEW: http://review.gluster.org/8017 (glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.) posted (#9) for review on master by Sachin Pandit (spandit)

Comment 9 Anand Avati 2014-06-12 07:45:44 UTC
REVIEW: http://review.gluster.org/8017 (glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.) posted (#10) for review on master by Sachin Pandit (spandit)

Comment 10 Anand Avati 2014-06-12 10:18:35 UTC
REVIEW: http://review.gluster.org/8017 (glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.) posted (#11) for review on master by Sachin Pandit (spandit)

Comment 11 Anand Avati 2014-06-12 13:19:49 UTC
REVIEW: http://review.gluster.org/8017 (glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.) posted (#12) for review on master by Sachin Pandit (spandit)

Comment 12 Anand Avati 2014-06-13 09:12:37 UTC
COMMIT: http://review.gluster.org/8017 committed in master by Vijay Bellur (vbellur) 
------
commit 10cd2bc38e1f0a1297d59c0791a85ed9d01c93ff
Author: Sachin Pandit <spandit>
Date:   Wed Jun 11 09:03:16 2014 +0530

    glusterd/snapshot : Provide enable/disable option for snapshot auto-delete feature.
    
    This patch provides an interface to enable or disable
    the auto-delete feature.
    Syntax : gluster snapshot config auto-delete <enable/disable>
    
    DETAILS :
    
    1) When auto-delete feature is disabled, If the the soft-limit is
    reached then user is given a warning about exceeding soft-limit
    along with successful snapshot creation message (oldest snapshot is
    not deleted). And upon reaching hard-limit further snapshot creation
    is not allowed.
    
    Example :
    ------------------------------------------------------------------
    |Case - 1: Upon reaching soft-limit
    |
    |Snapshot create : snap successfully created.
    |Warning : soft-limit of volume (vol) is reached. Snapshot creation
    |is not possible once hard-limit is reached.
    |
    |-----------------------------------------------------
    |Case - 2: Upon reaching hard-limit
    |
    |Snapshot create : snap creation failed.
    |Error : hard-limit of volume (vol) is reached, Hence it is not
    |possible to take further snapshots. Please delete few snapshots
    |of the volume (vol) before taking another snapshot.
    ------------------------------------------------------------------
    
    2) When auto-delete feature is enabled, then as soon as the soft-limit
    is reached the oldest snapshot is deleted for every successful snapshot
    creation (same as existing method), With this it is made sure that
    number of snapshot created is not more than snap-max-hard-limit.
    
    Change-Id: Ie3ca64bbd2c763371f541cd2e378314e73b695b4
    BUG: 1105415
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/8017
    Tested-by: Justin Clift <justin>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 13 Niels de Vos 2014-09-22 12:42:17 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 14 Niels de Vos 2014-11-11 08:34:30 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users