Bug 1105531

This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=6928547

(This is not a Rename request ... fedora-create-review is just stupid).

No issue noted, except the license file missing, but since that's directly in the sole and
only file, I think that's acceptable. Hence approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gen-oath-safe-0.9.0-1.fc20.noarch.rpm
          gen-oath-safe-0.9.0-1.fc20.src.rpm
gen-oath-safe.noarch: W: spelling-error %description -l en_US textmode -> text mode, text-mode, outmoded
gen-oath-safe.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically
gen-oath-safe.noarch: W: no-manual-page-for-binary gen-oath-safe
gen-oath-safe.src: W: spelling-error %description -l en_US textmode -> text mode, text-mode, outmoded
gen-oath-safe.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically
2 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint gen-oath-safe
gen-oath-safe.noarch: W: spelling-error %description -l en_US textmode -> text mode, text-mode, outmoded
gen-oath-safe.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically
gen-oath-safe.noarch: W: no-manual-page-for-binary gen-oath-safe
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'



Requires
--------
gen-oath-safe (rpmlib, GLIBC filtered):
    /bin/bash
    caca-utils
    file
    openssl
    python
    qrencode



Provides
--------
gen-oath-safe:
    gen-oath-safe



Source checksums
----------------
https://github.com/mcepl/gen-oath-safe/archive/0.9.0/gen-oath-safe-0.9.0.tar.gz :
  CHECKSUM(SHA256) this package     : b95702628b2b9c3fe1ee2fa1bd49d4a0226a5697d1c204918379a0e654108839
  CHECKSUM(SHA256) upstream package : b95702628b2b9c3fe1ee2fa1bd49d4a0226a5697d1c204918379a0e654108839


Generated by fedora-review 0.4.0 (cf29f98) last change: 2013-02-08
Command line :./try-fedora-review -b 1105531
Buildroot used: fedora-20-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

New Package SCM Request
=======================
Package Name: gen-oath-safe
Short Description:  Script for generating HOTP/TOTP keys (and QR code)
Upstream URL: https://github.com/mcepl/gen-oath-safe
Owners: mcepl
Branches: el6 f20
InitialCC:

Git done (by process-git-requests).

Package Change Request
======================
Package Name: gen-oath-safe
New Branches: epel7
Owners: mcepl

Git done (by process-git-requests).

http://koji.fedoraproject.org/koji/buildinfo?buildID=521539

gen-oath-safe-0.9.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/gen-oath-safe-0.9.0-1.el6

gen-oath-safe-0.9.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/gen-oath-safe-0.9.0-1.fc20

gen-oath-safe-0.9.0-1.fc20 has been pushed to the Fedora 20 stable repository.

gen-oath-safe-0.9.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.