Bug 1105743
Summary: | Viewing operation details for operations with no results causes Globally uncaught exception in UI - java.lang.IllegalArgumentException:Null configuration. | ||
---|---|---|---|
Product: | [JBoss] JBoss Operations Network | Reporter: | Larry O'Leary <loleary> |
Component: | Operations, Storage Node | Assignee: | Jirka Kremser <jkremser> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Sunil Kondkar <skondkar> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | JON 3.2.1 | CC: | myarboro, skondkar |
Target Milestone: | ER01 | Keywords: | Regression, Triaged |
Target Release: | JON 3.2.3 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-09-05 15:40:51 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1103375 | ||
Bug Blocks: |
Description
Larry O'Leary
2014-06-07 00:08:57 UTC
Jirka, Would you mind taking a look at this? If you are not able to, just go ahead and reassign it back to me. Thanks. Reproduced here http://jk-bz1105743-1.bc.jonqe.lab.eng.bos.redhat.com:7080/coregui/#Resource/10093/Operations/History/10005 on JON 3.2.0 GA This was already fixed in master by bug 1103375 The bug is targeted to 3.3 that will be based on master, so lets wait for the fork (=> leaving it on ASSIGNED) Here is a patch if needed, for hotfix (added 1 null check for operationHistory.getResults()) diff --git a/modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/inventory/resource/detail/operation/history/ResourceOperationHistoryDetailsView.java b/modu index 1264343..6b8dd08 100644 --- a/modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/inventory/resource/detail/operation/history/ResourceOperationHistoryDetailsView.java +++ b/modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/inventory/resource/detail/operation/history/ResourceOperationHistoryDetailsView.java @@ -27,6 +27,7 @@ import com.smartgwt.client.widgets.Label; import com.smartgwt.client.widgets.form.fields.FormItem; import com.smartgwt.client.widgets.form.fields.StaticTextItem; +import org.rhq.core.domain.configuration.Configuration; import org.rhq.core.domain.configuration.definition.ConfigurationDefinition; import org.rhq.core.domain.criteria.ResourceOperationHistoryCriteria; import org.rhq.core.domain.operation.GroupOperationHistory; @@ -137,11 +138,11 @@ public class ResourceOperationHistoryDetailsView extends AbstractOperationHistor OperationDefinition operationDefinition = operationHistory.getOperationDefinition(); ConfigurationDefinition resultsConfigurationDefinition = operationDefinition .getResultsConfigurationDefinition(); - if (resultsConfigurationDefinition != null - && !resultsConfigurationDefinition.getPropertyDefinitions().isEmpty() - && operationHistory.getResults() != null) { - ConfigurationEditor editor = new ConfigurationEditor( - operationDefinition.getResultsConfigurationDefinition(), operationHistory.getResults()); + Configuration results = operationHistory.getResults(); + if (resultsConfigurationDefinition != null && results != null + && !resultsConfigurationDefinition.getPropertyDefinitions().isEmpty()) { + + ConfigurationEditor editor = new ConfigurationEditor(resultsConfigurationDefinition, results); editor.setPreserveTextFormatting(true); editor.setReadOnly(true); resultsSection.addMember(editor); branch: release/jon3.2.x link: https://github.com/rhq-project/rhq/commit/ff3591dec time: 2014-06-25 14:31:41 +0200 commit: ff3591dec255c9a5357fdc45b742b7af6365840b author: Jay Shaughnessy - jshaughn message: [BZ 1105743] - Viewing operation details for operations with no results causes Globally uncaught exception in UI - java.lang.IllegalArgumentException:Null configuration. - BZ 1103375 for RHQ - Handled cases where null results are returned from an operation excecution. - Fixed one op history update path where [results] data could be lost. (cherry picked from commit ed8a2c4ce29920559febbd23129db6d9afa77d99) Signed-off-by: Jirka Kremser <jkremser> Conflicts: modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/admin/topology/AgentDetailView.java Moving to ON_QA as this is available for test in JON 3.2.3 ER01 build: http://jon01.mw.lab.eng.bos.redhat.com:8042/dist/release/jon/3.2.3.GA/8-14-14/ Verified on version : 3.2.0.GA Update 03 Build Number :bca1bc8:e19c43d Verified that there is no error/exception on clicking the operation link for the operation where no result is returned |