Bug 1105891

Summary: features/gfid-access: stat on .gfid virtual directory return EINVAL
Product: [Community] GlusterFS Reporter: Kotresh HR <khiremat>
Component: geo-replicationAssignee: Kotresh HR <khiremat>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: mainlineCC: aavati, bengland, csaba, gluster-bugs, khiremat, mpillai, nkhare, nlevinki, vbellur
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.5.2beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1103155 Environment:
Last Closed: 2014-07-31 11:43:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1103155    
Bug Blocks: 1104511    

Comment 1 Anand Avati 2014-06-08 18:31:17 UTC
REVIEW: http://review.gluster.org/8011 (feautre/gfid-access: Fix EINVAL when stat on .gfid) posted (#1) for review on master by Kotresh HR (khiremat)

Comment 3 Anand Avati 2014-06-09 08:59:45 UTC
REVIEW: http://review.gluster.org/8011 (feautre/gfid-access: Fix EINVAL when stat on .gfid) posted (#2) for review on master by Kotresh HR (khiremat)

Comment 4 Kotresh HR 2014-06-09 09:16:54 UTC
Description of problem 
stat on .gfid virtual directory is resulting in EINVAL from dht
saying dht layout not found. Other inode operations on '.gfid' are also hitting 
the same.

Actual Result:
Inode operations on '.gfid' should returns EINVAL reaching dht on layout not found.

Expcected Result:
Inode operations on '.gfid' virtual directory should return 'ENOTSUP' if not supported and success if supported. It should not wind further down the gfid-access translator.

Comment 5 Anand Avati 2014-06-10 05:57:00 UTC
REVIEW: http://review.gluster.org/8011 (feautre/gfid-access: Fix EINVAL when stat on .gfid) posted (#3) for review on master by Kotresh HR (khiremat)

Comment 6 Anand Avati 2014-06-10 06:30:32 UTC
REVIEW: http://review.gluster.org/8011 (feautre/gfid-access: Fix EINVAL when stat on .gfid) posted (#4) for review on master by Kotresh HR (khiremat)

Comment 7 Anand Avati 2014-06-16 10:32:37 UTC
REVIEW: http://review.gluster.org/8011 (feautre/gfid-access: Fix EINVAL when stat on .gfid) posted (#5) for review on master by Kotresh HR (khiremat)

Comment 8 Anand Avati 2014-06-19 05:54:59 UTC
REVIEW: http://review.gluster.org/8011 (feautre/gfid-access: Fix EINVAL when stat on .gfid) posted (#6) for review on master by Kotresh HR (khiremat)

Comment 9 Anand Avati 2014-06-20 09:22:07 UTC
COMMIT: http://review.gluster.org/8011 committed in master by Vijay Bellur (vbellur) 
------
commit 78e9180ca24f15e1366eb3d51cbb5e4576af91a2
Author: Kotresh H R <khiremat>
Date:   Fri Jun 6 03:27:21 2014 +0530

    feautre/gfid-access: Fix EINVAL when stat on .gfid
    
    Problem: Some of the inode operations on '.gfid'
    virtual directory was resulting in the error
    EINVAL from dht after failing to find the layout.
    
    Solution: Inode operations on '.gfid' virtual directory
    should not wind further down and should be handled
    accordingly in the gfid-access translator itself.
    
    Change-Id: I156cb10ffea0c46b0d747e26f74538d7fb01a1dd
    BUG: 1105891
    Signed-off-by: Kotresh H R <khiremat>
    Reviewed-on: http://review.gluster.org/8011
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-by: Venky Shankar <vshankar>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 10 Anand Avati 2014-07-04 05:51:11 UTC
REVIEW: http://review.gluster.org/8234 (feautre/gfid-access: Fix EINVAL when stat on .gfid) posted (#1) for review on release-3.5 by Kotresh HR (khiremat)

Comment 11 Anand Avati 2014-07-07 07:22:34 UTC
COMMIT: http://review.gluster.org/8234 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit 193d3b348a6c657e51f2a62c8bd9726fb635d582
Author: Kotresh H R <khiremat>
Date:   Fri Jun 6 03:27:21 2014 +0530

    feautre/gfid-access: Fix EINVAL when stat on .gfid
    
    Problem: Some of the inode operations on '.gfid'
    virtual directory was resulting in the error
    EINVAL from dht after failing to find the layout.
    
    Solution: Inode operations on '.gfid' virtual directory
    should not wind further down and should be handled
    accordingly in the gfid-access translator itself.
    
    Change-Id: I156cb10ffea0c46b0d747e26f74538d7fb01a1dd
    BUG: 1105891
    Signed-off-by: Kotresh H R <khiremat>
    Reviewed-on: http://review.gluster.org/8011
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-by: Venky Shankar <vshankar>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/8234
    Reviewed-by: Niels de Vos <ndevos>

Comment 12 Niels de Vos 2014-07-21 15:41:35 UTC
The first (and last?) Beta for GlusterFS 3.5.2 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.2beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-devel/2014-July/041636.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 13 Niels de Vos 2014-07-31 11:43:06 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.2, please reopen this bug report.

glusterfs-3.5.2 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-July/041217.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user