Bug 1105932

Summary: TeXmacs: FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Dennis Gilmore <dennis>
Component: TeXmacsAssignee: Jindrich Novy <novyjindrich>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: novyjindrich, orion, rdieter, yselkowi
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-09 19:24:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 245418, 1105908    
Attachments:
Description Flags
build.log
none
root.log
none
state.log
none
Patch for rawhide
none
Fix qreal-to-double casting error none

Description Dennis Gilmore 2014-06-09 02:06:53 UTC 
Your package TeXmacs failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6932059

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
Comment 1 Dennis Gilmore 2014-06-09 02:06:56 UTC 
Created attachment 903396 [details]
build.log
Comment 2 Dennis Gilmore 2014-06-09 02:06:58 UTC 
Created attachment 903397 [details]
root.log
Comment 3 Dennis Gilmore 2014-06-09 02:07:00 UTC 
Created attachment 903398 [details]
state.log
Comment 4 Yaakov Selkowitz 2014-06-12 18:51:26 UTC 
Created attachment 908260 [details]
Patch for rawhide

configure was enabling ghostscript support based on presence of gs(1), but while it is a Requires, it was not a BR; it's not actually used during the build.  Patch for rawhide attached.
Comment 5 Jindrich Novy 2014-06-24 08:03:09 UTC 
Yaakov, thanks for the patch. It's now applied along with the 1.99.1 update.
Comment 6 Yaakov Selkowitz 2014-07-16 21:58:57 UTC 
Unfortunately 1.99.1 didn't build successfully:

http://koji.fedoraproject.org/koji/taskinfo?taskID=7070145

Looks like you need to add an -lz.
Comment 7 Rex Dieter 2014-08-19 13:02:47 UTC 
OK, comment #6 problem fixed

* Thu Jul 31 2014 Yaakov Selkowitz <yselkowi> - 1.99.1-2
- Add missing -lz to link (#1105932)


Now, we're down to a failure on arm where the source code is making assumptions that qreal=double (so it fails on arm platforms where qreal is float).
Comment 8 Yaakov Selkowitz 2014-08-20 03:10:35 UTC 
Created attachment 928592 [details]
Fix qreal-to-double casting error

AFAICS this commit is the culprit:

http://svn.savannah.gnu.org/viewvc?view=rev&root=texmacs&revision=7394

But this can't just be reverted entirely because other code now uses the 4-argument encode function.  The attached patch should fix this without losing the intended functionality, and built successfully in rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=7429414
Comment 9 Orion Poplawski 2014-12-09 19:24:03 UTC 
I checked this patch in and built it.