Bug 1106364

Summary:	Review Request: perl-MooX-Types-MooseLike-Numeric - Moo types for numbers
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-MooX-Types-MooseLike-Numeric-1.02-2.fc19	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-29 02:53:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1105958

Description Ralf Corsepius 2014-06-09 07:39:51 UTC

Spec URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-Types-MooseLike-Numeric.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-Types-MooseLike-Numeric-1.02-1.fc21.src.rpm
Description: Moo types for numbers
Fedora Account System Username: corsepiu

This package is a new mandatory requirement of newer versions of perl-CHI.

Comment 1 Petr Šabata 2014-06-17 09:06:25 UTC

Taking the review.

Comment 2 Petr Šabata 2014-06-17 09:13:22 UTC

The %description could definitely use some improvements -- at least capitalize the first word and end it with a fullstop.

Other suggestions, as usually:
BR perl
s/PERL_INSTALL_ROOT/DESTDIR/

The rest is fine.

Comment 3 Ralf Corsepius 2014-06-18 09:23:29 UTC

Updated package:

Spec URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-Types-MooseLike-Numeric.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-Types-MooseLike-Numeric-1.02-2.fc21.src.rpm

Comment 4 Petr Šabata 2014-06-19 11:35:58 UTC

Ack.

Comment 5 Ralf Corsepius 2014-06-19 14:40:51 UTC

Thanks for the review, Petr.

New Package SCM Request
=======================
Package Name: perl-MooX-Types-MooseLike-Numeric
Short Description: Moo types for numbers
Upstream URL: http://search.cpan.org/dist/MooX-Types-MooseLike-Numeric/
Owners: corsepiu
Branches: f19 f20
InitialCC: perl-sig

Comment 6 Kevin Fenzi 2014-06-19 20:55:45 UTC

Git done (by process-git-requests).

Comment 7 Fedora Update System 2014-06-20 08:07:53 UTC

perl-MooX-Types-MooseLike-Numeric-1.02-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-MooX-Types-MooseLike-Numeric-1.02-2.fc19

Comment 8 Fedora Update System 2014-06-21 02:57:33 UTC

perl-MooX-Types-MooseLike-Numeric-1.02-2.fc19 has been pushed to the Fedora 19 testing repository.

Comment 9 Fedora Update System 2014-06-29 02:53:39 UTC

perl-MooX-Types-MooseLike-Numeric-1.02-2.fc19 has been pushed to the Fedora 19 stable repository.