Bug 1106406

Summary:	[SNAPSHOT]: glusterd log prints "invalid snap command" warning for every successful snapshot status
Product:	[Community] GlusterFS	Reporter:	Sachin Pandit <spandit>
Component:	glusterd	Assignee:	Sachin Pandit <spandit>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs, nsathyan, rhinduja
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:	SNAPSHOT
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1106404	Environment:
Last Closed:	2014-11-11 08:34:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1106404
Bug Blocks:

Description Sachin Pandit 2014-06-09 09:35:07 UTC

+++ This bug was initially created as a clone of Bug #1106404 +++

Description of problem:
=======================

Whenever snapshot command is successful against snapname or volumename, the glusterd logs prints a warning message as "invalid snap command" on all the nodes in cluster.

For example:
============

[root@rhs-arch-srv2 ~]# gluster snapshot status a40 | grep "Snap Name"
Snap Name : a40
[root@rhs-arch-srv2 ~]# 

glusterd logs:
==============

[2014-06-09 09:27:56.478558] W [glusterd-snapshot.c:6489:glusterd_snapshot_postvalidate] 0-management: invalid snap command



Version-Release number of selected component (if applicable):
=============================================================


glusterfs-3.6.0.14-1.el6rhs.x86_64

How reproducible:
=================
1/1


Steps to Reproduce:
===================
1. Create and start a volume
2. Create a snapshot of a volume
3. Check the status of snapshot using
"gluster snapshot status <snap-name> | volume <vol-name>"
4. Check the glusterd logs

Actual results:
===============

[2014-06-09 09:27:56.478558] W [glusterd-snapshot.c:6489:glusterd_snapshot_postvalidate] 0-management: invalid snap command


Expected results:
=================

Warning should not be logged for successful and valid snap command.

--- Additional comment from Sachin Pandit on 2014-06-09 05:34:43 EDT ---

The patch which fixes this problem has been posted upstream.
http://review.gluster.org/#/c/8014/

Comment 1 Anand Avati 2014-06-09 09:35:55 UTC

REVIEW: http://review.gluster.org/8014 (glusterd/snapshot : override postvalidate for snapshot status and snapshot config command.) posted (#2) for review on master by Sachin Pandit (spandit)

Comment 2 Anand Avati 2014-06-10 07:12:58 UTC

REVIEW: http://review.gluster.org/8014 (glusterd/snapshot : override postvalidate for few snapshot commands.) posted (#3) for review on master by Sachin Pandit (spandit)

Comment 3 Anand Avati 2014-06-16 11:09:35 UTC

COMMIT: http://review.gluster.org/8014 committed in master by Kaushal M (kaushal) 
------
commit 452eea5c43ee5af450e91f240860551af6aba241
Author: Sachin Pandit <spandit>
Date:   Mon Jun 9 07:52:37 2014 +0530

    glusterd/snapshot : override postvalidate for few snapshot commands.
    
    snapshot info, list, config display and status does not
    require any operations to be performed during postvalidate stage.
    Hence it is better to override these commands in postvalidate.
    Or else there will be a warning in log message saying "postvalidation
    failed".
    
    Change-Id: I14d64f7bf9adee8821067dd74d5027215d7b02f8
    BUG: 1106406
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/8014
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Kaushal M <kaushal>

Comment 4 Niels de Vos 2014-09-22 12:42:27 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 5 Niels de Vos 2014-11-11 08:34:40 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users