Bug 1106413

Summary: psql wrapper always return zero even if psql command is already failed.
Product: OpenShift Online Reporter: Johnny Liu <jialiu>
Component: ImageAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: jokerman, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1106414 (view as bug list) Environment:
Last Closed: 2014-07-15 10:30:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1106414    

Description Johnny Liu 2014-06-09 09:45:06 UTC
Description of problem:
Check psql wrapper function in /usr/bin/rhcsh, psql command's return value is always return 0.

Version-Release number of selected component (if applicable):
devenv_4850

How reproducible:
Always

Steps to Reproduce:
1.Create app, and embed postgresql.
2.Log into this app, run psql command with non-existing file.
> psql -f xx; echo $?
psql: FATAL:  password authentication failed for user "admin1hygbvy"
0
3.

Actual results:
It always return 0.

Expected results:
Psql wrapper should return non-zero value when psql command is failed.

Additional info:

Comment 1 openshift-github-bot 2014-06-11 14:47:00 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/73808983505a93095351d503742809a343b36de5
Bug 1106413: psql wrapper always return zero even if psql command is already failed

Comment 2 Johnny Liu 2014-06-12 04:15:01 UTC
Verified this bug with devenv_4860, and PASS.

> psql -f xx; echo $?
xx: No such file or directory
1