Bug 110738

Summary: bad source code
Product: [Fedora] Fedora Reporter: d.binderman
Component: diaAssignee: Dan Williams <dcbw>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 1CC: alexl
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-09-19 22:08:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description d.binderman 2003-11-24 12:37:20 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows 98)

Description of problem:

Hello there,

I just tried to compile package dia-0_91-2 from Fedora.

The compiler said

svg-import.c(559): remark #592: variable "end" is used before its 
value is set

The source code is

  Point start,end;

  // ...

  ptprop->point_data = end;

By inspection of the source code, I agree with the compiler. This code
needs rework.


Version-Release number of selected component (if applicable):
dia-0_91-2 

How reproducible:
Always

Steps to Reproduce:
1. compile with flag -Wall.
2.
3.
    

Additional info:

Comment 1 Dan Williams 2004-05-14 22:26:36 UTC
Alex, is this legit?  From a strict perspective, it is.  Comments?

Comment 2 d.binderman 2004-05-31 07:30:40 UTC
Still broken in Fedora Core 2 :-<

Comment 3 Dan Williams 2004-08-18 18:05:19 UTC
Fixed in dia-0.94-2

Comment 4 Dan Williams 2004-09-19 22:08:13 UTC
Also now fixed upstream, gnome bug #150548.