Bug 110758

Summary: bad source code
Product: [Fedora] Fedora Reporter: d.binderman
Component: gnome-themesAssignee: Alexander Larsson <alexl>
Status: CLOSED UPSTREAM QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 1   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-10-05 14:33:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description d.binderman 2003-11-24 14:54:46 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows 98)

Description of problem:

I just tried to compile package gnome-themes-2_4_0-1 from Fedora.

The compiler said

eazel-theme-hacks.c(122): remark #592: variable "child_list" is used 
before its value is set

The source code is

    GList *child_list, *child;

	/* more code */

    for (child = child_list; child; child = child->next)

I agree with the compiler. This could would benefit from rework.




Version-Release number of selected component (if applicable):
gnome-themes-2_4_0-1 

How reproducible:
Always

Steps to Reproduce:
1. by inspection
2.
3.
    

Additional info:

Comment 1 Alexander Larsson 2004-10-05 14:33:25 UTC
Bug filed upstream at:
http://bugzilla.gnome.org/show_bug.cgi?id=154567