Bug 110803
| Summary: | bad source code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | d.binderman |
| Component: | gv | Assignee: | Dan Williams <dcbw> |
| Status: | CLOSED RAWHIDE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 1 | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2004-05-14 22:22:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
(2) is fixed in -27, and (1) appears to be correct code. |
From Bugzilla Helper: User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows 98) Description of problem: I just tried to compile package gv-3_5_8-23 from Fedora. The compiler said 1. callbacks.c(1142): warning #187: use of "=" where "==" may have been intended The source code is if ((x != p->psx) || (y != p->psy) || (buf[0]='\0')) { Better might be if ((x != p->psx) || (y != p->psy) || (buf[0] == '\0')) { 2. process.c(291): warning #175: subscript out of range The source code is char *argv[3]; /* more code */ argv[3] = NULL; Suggest make argv one bigger. Version-Release number of selected component (if applicable): gv-3_5_8-23 How reproducible: Always Steps to Reproduce: 1. by inspection 2. 3. Additional info: