Bug 1108070

Summary: kie-maven-plugin throws error when kmodule including kbase
Product: [Retired] JBoss BRMS Platform 6 Reporter: Amana <ajuricic>
Component: Build and AssemblyAssignee: Mario Fusco <mfusco>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Locker <jlocker>
Severity: high Docs Contact:
Priority: high    
Version: 6.0.1CC: agiertli, etirelli, mbaluch, paradhya, rrajasek, vigoyal
Target Milestone: CR1   
Target Release: 6.0.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
A project that tried to include a kbase by specifying it through the kmodule.xml: <kbase name="kbase2" includes="kbase1"> would fail compilation. The compilation error was that the included kbase1 could not be found. An incorrect way of loading dependencies for a project caused this issue. This has now been fixed and projects can successfully include external kbase specified through the kmodule.xml file.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 19:53:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
kiebase-inclusion-6.0.1.7z
none
named-kiesession-6.0.1.7z none

Description Amana 2014-06-11 12:13:33 UTC
Created attachment 907615 [details]
kiebase-inclusion-6.0.1.7z

Description of problem:

An error is experiencied by building a project that contains a kmodule.xml which uses an include such as:

    <kbase name="kbase2" includes="kbase1"> 

When generating a kjar there is an error indicating the included kbase could not be found:

[ERROR] Message [id=1, level=ERROR, path=src/main/resources/META-INF/kmodule.xml, line=0, column=0
   text=Unable to build KieBase, could not find include: kbase1]

If using brms version 6.0.2-SNAPSHOT the build succeeds but with the release version 6.0.2-redhat-6 it fails. 


Version-Release number of selected component (if applicable):

BRMS 6.0.1

How reproducible:

Always

Steps to Reproduce:
1. Download attached files (named-kiesession-6.0.1.7z and kiebase-inclusion-6.0.1.7z);
2. unzip and 'mvn install' named-kiesession-6.0.1 project. It should be built successfully.
3. unzip and 'mvn install' kiebase-inclusion-6.0.1 project. It will throw the error above.

Actual results:

[ERROR] Message [id=1, level=ERROR, path=src/main/resources/META-INF/kmodule.xml, line=0, column=0
   text=Unable to build KieBase, could not find include: kbase1]

Expected results:

It should build succesfully.

Additional info:

Comment 1 Amana 2014-06-11 12:14:27 UTC
Created attachment 907616 [details]
named-kiesession-6.0.1.7z

Comment 2 Amana 2014-06-11 12:16:04 UTC
> By 6.0.2-SNAPSHOT, does he mean community? Or a build out of the
product branch? Where is he getting that from?

6.0.2-SNAPSHOT is referred to in the source code
distributed by Red Hat in jboss-bpms-brms-6.0.0.GA-redhat-2-source.zip.

Comment 4 Edson Tirelli 2014-06-11 13:11:48 UTC
Amana, sorry, but still confused by this:

> 6.0.2-SNAPSHOT is referred to in the source code
distributed by Red Hat in jboss-bpms-brms-6.0.0.GA-redhat-2-source.zip.

You mean that this test fails with the product binaries, but work if building the product source code and using it? Can you please clarify?

Mario, can you please check if you are able to reproduce it using our current 6.0.x branch?

Comment 5 Mario Fusco 2014-06-12 13:10:33 UTC
The implementation of this use case was totally missing, so I don't see how it could have ever worked.

Fixed by https://github.com/droolsjbpm/drools/commit/7320e0cfd

Comment 6 Mario Fusco 2014-06-12 13:12:05 UTC
Cherry-picked to 6.1.x branch with https://github.com/droolsjbpm/drools/commit/d1f267f5e

Comment 7 Mario Fusco 2014-06-12 15:21:52 UTC
Cherry-picked to 6.0.x branch with https://github.com/droolsjbpm/drools/commit/9fa4169c6

Comment 8 Jiri Locker 2014-06-19 13:21:48 UTC
I used the attached project and reproduced the problem with 6.0.3-redhat-2 dependencies (6.0.2.ER3) and verified it is fixed with 6.0.3-redhat-3 (6.0.2.CR1) dependencies.

Interestingly, I couldn't reproduce in Business Central 6.0.2.ER3.