Bug 1108095
| Summary: | rhq.storage.request.limit is overridden by rhq.storage.request.limit.topology-delta on start-up | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [JBoss] JBoss Operations Network | Reporter: | Armine Hovsepyan <ahovsepy> | ||||||
| Component: | Configuration, Storage Node | Assignee: | Michael Burman <miburman> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Armine Hovsepyan <ahovsepy> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | JON 3.2 | CC: | jsanda, mfoley, miburman, myarboro | ||||||
| Target Milestone: | ER04 | ||||||||
| Target Release: | JON 3.3.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-12-11 14:03:43 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1146138 | ||||||||
| Bug Blocks: | 1098243 | ||||||||
| Attachments: |
|
||||||||
To me this seems intentional, I'm not sure if we need request.limit at all? The idea seems to be that we increase the request limit based on the amount of nodes up. rhq.storage.request.limit is only used to initialize RateLimiter, but then it is instantly overridden with calculated value. John, was the plan to use storage-limit as hard-quota or is it just something left over from the past? Work is now done in PR 131. Fixed in master:
commit 328cecabaa662cccc0f1d136576c2883c45ca54a
Author: Michael Burman <miburman>
Date: Fri Sep 26 14:08:35 2014 +0300
[BZ 1108095] Updating topology delta will automatically change requestLimit. RequestLimit is no longer allowed to be edited directly
commit 6958d627983c66813ad12f0e7b42619ddbdfe7b0
Author: John Sanda <jsanda>
Date: Fri Sep 26 11:25:50 2014 -0400
[BZ 1108095] fix compiler errors
commit c6b482c1b687d70d7644ba91dd6c272f701cfd07
Author: Michael Burman <miburman>
Date: Fri Sep 26 17:36:27 2014 +0300
[BZ 1108095] Use topologyDelta instead of hard requestLimit for tests
After discussion with jsanda, cherry-picked to release/jon3.3.x:
commit cf00bbefe39eb8fe1ecb167e6a3a3238fd0ab0b4
Author: Michael Burman <miburman>
Date: Fri Sep 26 14:08:35 2014 +0300
[BZ 1108095] Updating topology delta will automatically change requestLimit. RequestLimit is no longer allowed to be edited directly
(cherry picked from commit 328cecabaa662cccc0f1d136576c2883c45ca54a)
commit d20de2f433c98659e3b0edf4ad772a51863c6c7e
Author: John Sanda <jsanda>
Date: Fri Sep 26 11:25:50 2014 -0400
[BZ 1108095] fix compiler errors
(cherry picked from commit 6958d627983c66813ad12f0e7b42619ddbdfe7b0)
commit 3233bd4902c80f2fba7b15c51bb171fcb15d27ac
Author: Michael Burman <miburman>
Date: Fri Sep 26 17:36:27 2014 +0300
[BZ 1108095] Use topologyDelta instead of hard requestLimit for tests
(cherry picked from commit c6b482c1b687d70d7644ba91dd6c272f701cfd07)
Moving to ON_QA as available for test with build: https://brewweb.devel.redhat.com/buildinfo?buildID=388959 verified in JON 3.3 ER04 screen-shot attached Created attachment 944584 [details]
rhq.storage.request.limit.topology-delta
|
Created attachment 907620 [details] default_throttling.log Description of problem: rhq.storage.request.limit is overridden by rhq.storage.request.limit.topology-delta on start-up Version-Release number of selected component (if applicable): rhq master How reproducible: always Steps to Reproduce: 1. install rhq server, storage and agent 2. stop services by rhqctl stop 3. change the default throttling values so that e.g. rhq.storage.request.limit=5000 rhq.storage.request.limit.topology-delta=3000 4. call rhqctl start Actual results: rhq.storage.request.limit is overridden by rhq.storage.request.limit.topology-delta on start-up Expected results: rhq.storage.request.limit is NOT overridden by rhq.storage.request.limit.topology-delta on start-up Additional info: see attached the value change log