Bug 1108129

@Remi

This latest release appears to have fixed the issue you patched for bug #1103219 [ http://pkgs.fedoraproject.org/cgit/php-doctrine-orm.git/commit/?id=bd8e1f31db0de633a686cd402ff72a3e8b341e29 ].  Read through the conversation at https://github.com/doctrine/doctrine2/pull/1045 .  Please confirm that this version contains the fix you required and I will update the package and remove the patch.

The code in upstream 2.4.3 is broken.

Fix proposal:

-            if (PHP_VERSION_ID === 50429 || PHP_VERSION_ID === 50513) {
+            if (version_compare(PHP_VERSION, '5.4') >= 0) {

unserialize(sprintf('O:%d:"%s":0:{}'...) is just an awfull hack which shouldn't exist.. and should be used as less as possible.

Perhaps it will be usable again in 5.4.30/5.5.14, but in all case it will not be supported anymore in PHP 5.6+

Perhaps checking for internal class will be better (not tested)

-   if (PHP_VERSION_ID === 50429 || PHP_VERSION_ID === 50513) {
+   if (version_compare(PHP_VERSION, '5.4') >= 0 
+       && !$this->reflClass->isInternal()) {

See upstream comment:
https://github.com/doctrine/doctrine2/commit/530c01b5e3ed7345cde564bd511794ac72f49b65#commitcomment-6636227

Latest upstream release: 2.4.4
Current version/release in Fedora Rawhide: 2.4.2-4.fc21
URL: https://github.com/doctrine/doctrine2/tags

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at:
https://fedoraproject.org/wiki/Upstream_release_monitoring

Probably the simple way to fix instantiator issue is to used the new doctrine/instantiator which will be shared by doctrine and phpunit.

See https://github.com/doctrine/doctrine2/commit/361ec2a474d78168473fb82a041f32c4b7665643

Latest upstream release: 2.4.5
Current version/release in Fedora Rawhide: 2.4.2-4.fc21
URL: https://github.com/doctrine/doctrine2/tags

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy


More information about the service that created this bug can be found at:
https://fedoraproject.org/wiki/Upstream_release_monitoring Soon this service will be implemented by a new system: https://github.com/fedora-infra/anitya/
It will require to manage monitored projects via a new web interface. Please make yourself familiar with the new system to ease the transition.

I've tested the patch Remi provides on my work app, that solves the issues that appears upgrading to PHP 5.6; ty :)

Latest upstream release: 2.4.6
Current version/release in Fedora Rawhide: 2.4.2-4.fc21
URL: https://github.com/doctrine/doctrine2/tags

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy


More information about the service that created this bug can be found at:
https://fedoraproject.org/wiki/Upstream_release_monitoring Soon this service will be implemented by a new system: https://github.com/fedora-infra/anitya/
It will require to manage monitored projects via a new web interface. Please make yourself familiar with the new system to ease the transition.

@Shawn 2.4.6 fix compatibility with PHP 5.6
(even if I don't really like their solution)

php-doctrine-orm-2.4.6-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/php-doctrine-orm-2.4.6-1.fc19

php-doctrine-orm-2.4.6-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-doctrine-orm-2.4.6-1.fc20

php-doctrine-orm-2.4.6-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/php-doctrine-orm-2.4.6-1.el7

php-doctrine-orm-2.4.6-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-doctrine-orm-2.4.6-1.el6

php-doctrine-orm-2.4.6-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/php-doctrine-orm-2.4.6-1.fc21

(In reply to Johan Cwiklinski from comment #7)
> I've tested the patch Remi provides on my work app, that solves the issues
> that appears upgrading to PHP 5.6; ty :)

(In reply to Remi Collet from comment #9)
> @Shawn 2.4.6 fix compatibility with PHP 5.6
> (even if I don't really like their solution)

THANKS guys!

As an extra bonus, unit tests are now included :)

Package php-doctrine-orm-2.4.6-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing php-doctrine-orm-2.4.6-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-12956/php-doctrine-orm-2.4.6-1.fc21
then log in and leave karma (feedback).

php-doctrine-orm-2.4.6-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

php-doctrine-orm-2.4.6-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

php-doctrine-orm-2.4.6-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

php-doctrine-orm-2.4.6-1.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.

php-doctrine-orm-2.4.6-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.