Bug 1108207

Summary:	[WebUI] When adding a condition to an automember rule, expression field should be required
Product:	Red Hat Enterprise Linux 7	Reporter:	Martin Kosek <mkosek>
Component:	ipa	Assignee:	Martin Kosek <mkosek>
Status:	CLOSED ERRATA	QA Contact:	Namita Soman <nsoman>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	7.1	CC:	rcritten
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ipa-4.0.3-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-05 10:11:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Kosek 2014-06-11 14:48:32 UTC

This bug is created as a clone of upstream ticket:
https://fedorahosted.org/freeipa/ticket/4053

Currently the `Expression` field is not required, which makes it possible to click on `Add` without filling in the expression. The dialog then closes without any errors, which gives the impression that the condition has been created for the rule, when in fact no condition gets created.

Additionally, if you click `Add and Add Another` without filling in the `Expression` field, a message saying `Entry successfully added` appears, which is wrong and misleading.

The `Expression` field should be required when adding a condition to the rule, for both inclusive and exclusive rules, as it does not makes sense to create a condition without an expression.

Comment 1 Martin Kosek 2014-06-11 15:23:31 UTC

This request is already fixed in upstream FreeIPA project. Please refer to the linked ticket for additional details and related commits.

Comment 3 Namita Soman 2015-01-27 01:53:49 UTC

verified using ipa-server-4.1.0-16.el7.x86_64

In the UI, took steps below to verify:
Add a group - groupone
Add a USergroup automember rule for this group
Edit this rule
Add a inclusive condition, select the attribute, but leave the expression blank. Click add, add and Add another...both indicate the expression is required
Tested the same with Exclusive expression.

Comment 5 errata-xmlrpc 2015-03-05 10:11:30 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0442.html