Bug 1108395

Spec URL: http://smani.fedorapeople.org/review/netgen-mesher.spec
SRPM URL: http://smani.fedorapeople.org/review/netgen-mesher-5.1-2.fc21.src.rpm

%changelog
* Thu Jun 12 2014 Sandro Mani <manisandro> - 5.1-2
- Split off libraries in libs subpackages
- Rename shared libraries to less generic names


Note: rpmlint will complain about *tons* of undefined-non-weak-symbols. These are caused by the fact that all libraries except libnglib are heavily under-linked. This could be fixed to some extent, but not completely (at least, not in a straight forward way), since the libng* libraries would have to be inter-linked, which is hard to so since link dependencies for one library have not yet been built, but conversely those link dependencies would need to be linked against the library currently being built. All these affected libraries seem to be private libraries, in the sense that only the netgen_mesher executable uses these, third-party code should only use libnglib, which is linked against the remaining libraries.

Spec URL: http://smani.fedorapeople.org/review/netgen-mesher.spec
SRPM URL: http://smani.fedorapeople.org/review/netgen-mesher-5.1-3.fc21.src.rpm

%changelog
* Thu Jun 12 2014 Sandro Mani <manisandro> - 5.1-3
- Fix libgnlib soname

Spec URL: http://smani.fedorapeople.org/review/netgen-mesher.spec
SRPM URL: http://smani.fedorapeople.org/review/netgen-mesher-5.1-4.fc21.src.rpm

* Fri Jun 13 2014 Sandro Mani <manisandro> - 5.1-4
- Update netgen-5.1_build.patch
- Add netgen-5.1_msc-ver.patch

Created attachment 915922 [details]
Comment

(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).

> ---> About this - Is there a specific reason why .desktop and icons are in -common instead of the base package?

Yes, you should theoretically be able to install just netgen-mesher-openmpi or netgen-mesher-mpich and then, when loading the respective MPI environment, i.e. /usr/lib64/openmpi/bin will be added to the PATH, and the desktop file should *theoretically* launch that executable. So putting the desktop file in common makes is valid for all variants of the netgen-mesher executable. Probably somewhat of an overkill, but yeah :)

> ---> Could this (and few more shared-libs-calls-exit) be fixed or brought to attention of the upstream folks?

Yes, could also try to get some of the patches upstreamed

> ---> From the build log and buildroot, the patches are applied during build. 

%autosetup does this


Spec URL: http://smani.fedorapeople.org/review/netgen-mesher.spec
SRPM URL: http://smani.fedorapeople.org/review/netgen-mesher-5.1-5.fc21.src.rpm

%changelog
* Sat Jun 14 2014 Sandro Mani <manisandro> - 5.1-5
- Add subpackage for private headers
- Add patches from salome
- Make common package noarch
- Add missing %%{?_isa}

Remarks about private headers and salome patch:
- Private headers are needed to compile the salome-smesh netgen plugin (which is in turn required for salome-meca -> code aster). Instead of going the way of a bundling exception and what not, I guess this is the simplest approach.
- Salome patches: reviewing the patch, they just fixed various issues with the code, not otherwise changing the behaviour of the code. So again, just patching the sources directly is easier than bundling a separate netgen in salome.

(In reply to Sandro Mani from comment #5)

> > ---> From the build log and buildroot, the patches are applied during build. 
> 
> %autosetup does this
> 

I may not have been clear here but I was not complaining. All was well here. :)

Looking at the rest now.

Sure, just to clarify ;)

Spec URL: http://smani.fedorapeople.org/review/netgen-mesher.spec
SRPM URL: http://smani.fedorapeople.org/review/netgen-mesher-5.1-6.fc21.src.rpm

%changelog
* Sat Jun 14 2014 Sandro Mani <manisandro> - 5.1-6
- Add netgen-5.1_relative-includes.patch

Isn't it better to call -private subpackage -private-devel since it contains headers

@@ -74,6 +75,13 @@
 %description    devel
 Development files for netgen.
 
+%package        private
+Summary:        Private headers of netgen
+Requires:       %{name}-devel%{?_isa} = %{version}-%{release}
+
+%description    private
+Private headers of netgen, needed to build certain netgen based software packages.
+
 
+# Install private headers
+(
+cd libsrc
+find \( -name *.hpp -or -name *.hxx -or -name *.h -or -name *.ixx -or -name *.jxx \) -exec install -Dpm 0644 {} %{buildroot}%{_includedir}/%{name}/private/{} \;
+)
+
  
+%files private
+%{_includedir}/%{name}/private
+

Good idea, I'll go with devel-private as was done in the qt package.

Spec URL: http://smani.fedorapeople.org/review/netgen-mesher.spec
SRPM URL: http://smani.fedorapeople.org/review/netgen-mesher-5.1-7.fc21.src.rpm

%changelog
* Sat Jun 14 2014 Sandro Mani <manisandro> - 5.1-7
- Rename subpackage private -> devel-private

Created attachment 915923 [details]
Comment

(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).

Spec updated (without release bump), and to my knowledge all versioned dependencies are correct.

(In reply to Sandro Mani from comment #12)
> .... to my knowledge all versioned
> dependencies are correct.

That's my "evaluation" as well.

Package Approved!

Thanks! Any time you need a review, just ping me!

New Package SCM Request
=======================
Package Name: netgen-mesher
Short Description: Automatic mesh generation tool
Owners: smani
Branches: f20
InitialCC:

Git done (by process-git-requests).

netgen-mesher-5.1-8.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/netgen-mesher-5.1-8.fc20

netgen-mesher-5.1-9.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/netgen-mesher-5.1-9.fc20

Created attachment 910517 [details]
EPEL6 fix

This doesn't build on EPEL6, which is what I'm interested in and which must be a
major platform for this sort of thing.
Patch attached in the hope it can get into EPEL.  It currently requires the
epel-testing repo.

Thanks for the patch. Do you want to maintain epel or should I do it (I'm happy to do so). Personally I'd probably apply the patch only in the epel branch.

Package netgen-mesher-5.1-9.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing netgen-mesher-5.1-9.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-7576/netgen-mesher-5.1-9.fc20
then log in and leave karma (feedback).

(In reply to Sandro Mani from comment #19)
> Thanks for the patch. Do you want to maintain epel or should I do it (I'm
> happy to do so). Personally I'd probably apply the patch only in the epel
> branch.

I don't yet have sponsorship, but I'm happy to send changes for gmsh/aster stuff
to work on EPEL6, at least, if that's OK.

Ok. Yeah, patches are always welcome, since personally I don't run EL often.

Package Change Request
======================
Package Name: netgen-mesher
New Branches: el6 epel7
Owners: smani
InitialCC:

Git done (by process-git-requests).

netgen-mesher-5.1-9.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

netgen-mesher-5.3.1-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/netgen-mesher-5.3.1-3.el6

netgen-mesher-5.3.1-3.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/netgen-mesher-5.3.1-3.el7

netgen-mesher-5.3.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository.

netgen-mesher-5.3.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository.