Bug 1108887

Summary:	[USS]: snapview-server should get the name of the entry by itself from path instead of depending on resolver
Product:	[Community] GlusterFS	Reporter:	Raghavendra Bhat <rabhat>
Component:	protocol	Assignee:	Raghavendra Bhat <rabhat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-11 08:34:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Raghavendra Bhat 2014-06-12 18:32:14 UTC

Description of problem:

Server resolver populates loc->name even while sending lookups on inodes directly (mostly revalidate lookups on inodes, nameless lookups just contain gfid as the path and no name) by getting the entry name from path. As of now the only dependent on this is the snapview-server xlator which needs the name to check whether the lookup is on entry point directory. So instead of server resolver doing this, it would be better if snapview-server itself can get the name from the path.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-06-12 18:35:37 UTC

REVIEW: http://review.gluster.org/8053 (get the path from the loc->path in the lookup instead of resolver doing it) posted (#1) for review on master by Raghavendra Bhat (raghavendra)

Comment 2 Anand Avati 2014-06-13 07:43:56 UTC

REVIEW: http://review.gluster.org/8053 (get the path from the loc->path in the lookup instead of resolver doing it) posted (#2) for review on master by Raghavendra Bhat (raghavendra)

Comment 3 Anand Avati 2014-06-13 16:54:56 UTC

COMMIT: http://review.gluster.org/8053 committed in master by Vijay Bellur (vbellur) 
------
commit a41f212e4b5bf74e2752370de10b754a1fa3f675
Author: Raghavendra Bhat <raghavendra>
Date:   Thu Jun 12 20:14:33 2014 +0530

    get the path from the loc->path in the lookup instead of resolver doing it
    
    Change-Id: I7448e1199f4fd32fb0ae127b36dcf06641a153a9
    BUG: 1108887
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/8053
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Niels de Vos 2014-09-22 12:42:47 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 5 Niels de Vos 2014-11-11 08:34:58 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users