Bug 1109049
| Summary: | Review Request: libcsv - small, simple and fast CSV library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Holcapek <holcapek> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lkundrak, package-review |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-05-02 19:49:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jan Holcapek
2014-06-13 07:16:58 UTC
$ rpmlint libcsv.spec ~/rpmbuild/SRPMS/libcsv-3.0.3-1.fc20.src.rpm ~/rpmbuild/RPMS/x86_64/libcsv{,-devel}-3.0.3-1.fc20.x86_64.rpm
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
This looks very nicely done.
* Package correctly named
* Latest version packaged
- License NOT correct (see below)
* License ok for Fedora
* SPEC file clean and legible
* Builds fine in mock
* Requires fine
* Provides fine
* Filelist fine
* Proper ldconfig scriptlets in place
There are some problems though:
0.) The license tag does not seem correct
According to libcsv.c it's LGPLv2+
1.) License text is missing
Please add %doc COPYING.LESSER. No idea why upstream ships GPL in COPYING; nothing seems to be GPL-ed in the library; no need to ship that file.
2.) It's customary for RPMs to be portable across installations with manpage compression turned off to do this:
-%doc %{_mandir}/man3/csv.3.gz
+%doc %{_mandir}/man3/csv.3*
3.) You may use %{version} macro to substitute versions for easier version upgrades. This one is completely up to you -- not a review blocker.
By the way, upstream seems to use a weird name for their library; they probably intended to use libcsv.so.3.0.3 instead of libcsv.so.3.0.2./csv.3.gz
(In reply to Lubomir Rintel from comment #2) > 0.) The license tag does not seem correct > > According to libcsv.c it's LGPLv2+ > > 1.) License text is missing > > Please add %doc COPYING.LESSER. No idea why upstream ships GPL in COPYING; > nothing seems to be GPL-ed in the library; no need to ship that file. Fixed. > 2.) It's customary for RPMs to be portable across installations with manpage > compression turned off to do this: > > -%doc %{_mandir}/man3/csv.3.gz > +%doc %{_mandir}/man3/csv.3* Fixed. > 3.) You may use %{version} macro to substitute versions for easier version > upgrades. This one is completely up to you -- not a review blocker. Followed the advice. > By the way, upstream seems to use a weird name for their library; they > probably intended to use libcsv.so.3.0.3 instead of libcsv.so.3.0.2./csv.3.gz This is yet to be addressed, thanks for your patience. (In reply to Jan Holcapek from comment #3) > > By the way, upstream seems to use a weird name for their library; they > > probably intended to use libcsv.so.3.0.3 instead of libcsv.so.3.0.2./csv.3.gz > > This is yet to be addressed, thanks for your patience. Looks like I've been able to fix this. Could you please re-review the spec and srpm? Thank you. Thank you. The package is APPROVED now. New Package SCM Request ======================= Package Name: libcsv Short Description: small, simple and fast CSV library Upstream URL: http://sourceforge.net/projects/libcsv/ Owners: holcapek Branches: f19 f20 el6 epel7 InitialCC: lkundrak I've accidentally switched fedore-review flag back to ?, so switching again to +. Git done (by process-git-requests). |