Bug 1109062

Summary: "Add-to" and "Remove-from" buttons needs to be disabled when no host-collection was listed/selected
Product: Red Hat Satellite Reporter: Sachin Ghai <sghai>
Component: WebUIAssignee: Brad Buckingham <bbuckingham>
Status: CLOSED CURRENTRELEASE QA Contact: sthirugn <sthirugn>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.0.3CC: bbuckingham, cwelton, jmontleo, sthirugn
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/6428
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-09-11 12:29:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
without selecting host-collection, clicking on "Add-to" button raising a confirmation dialog
none
rotating spinner with state "processing" on clicking 'yes' under confirmation dialog, none

Description Sachin Ghai 2014-06-13 07:44:15 UTC
Created attachment 908389 [details]
without selecting host-collection, clicking on "Add-to" button raising a confirmation dialog

Description of problem:
I was trying to perform bulk actions on selected content-hosts and choose "Host collections" tab from "Bulk Actions".

I found there was no host-collection listed. But "Add-To" and "Remove-From" button were enabled. When I clicked on "Add-To", a confirmation dialog appears too saying:

Are you sure you want to add the 2 content host(s) selected to the host collection(s) chosen?

Please see screenshot.

Since no host-collection was listed/selected, this msg is misleading for this case. So I think both buttons needs to be disbaled when no "host-collected was listed/selected.

Version-Release number of selected component (if applicable):
sat6 beta snap9 compose2 (Satellite-6.0.3-RHEL-6-20140612.1)

How reproducible:
always

Steps to Reproduce:
1. register 2-3 content-host
2. Go to content-host --> select 2-3 and click on "bulk Actions" 
3. select "Host-collection" tab
4. Click on "Add-To"

Actual results:
a confirmation dialog appears without selecting host-collection saying:

Are you sure you want to add the 2 content host(s) selected to the host collection(s) chosen?


And on clicking yes, UI went into "processing" state with a rotating spinner.



Expected results:
Buttons needs to be disabled, when no host-collection was listed/selected

Additional info:

Comment 1 Sachin Ghai 2014-06-13 07:52:04 UTC
Created attachment 908392 [details]
rotating spinner with state "processing" on clicking 'yes' under confirmation dialog,

Comment 2 RHEL Program Management 2014-06-13 08:05:06 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 4 Brad Buckingham 2014-06-28 19:59:29 UTC
Created redmine issue http://projects.theforeman.org/issues/6428 from this bug

Comment 5 Brad Buckingham 2014-06-28 20:50:42 UTC
proposed fix in PR: 

  https://github.com/Katello/katello/pull/4363

Comment 7 sthirugn@redhat.com 2014-09-03 19:14:19 UTC
Verified.

Version Tested:
GA Snap 7 - Satellite-6.0.4-RHEL-6-20140829.0

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.23-1.el6_5.noarch
* candlepin-common-1.0.1-1.el6_5.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.9.23-1.el6_5.noarch
* candlepin-tomcat6-0.9.23-1.el6_5.noarch
* elasticsearch-0.90.10-6.el6sat.noarch
* foreman-1.6.0.42-1.el6sat.noarch
* foreman-compute-1.6.0.42-1.el6sat.noarch
* foreman-gce-1.6.0.42-1.el6sat.noarch
* foreman-libvirt-1.6.0.42-1.el6sat.noarch
* foreman-ovirt-1.6.0.42-1.el6sat.noarch
* foreman-postgresql-1.6.0.42-1.el6sat.noarch
* foreman-proxy-1.6.0.30-1.el6sat.noarch
* foreman-selinux-1.6.0.14-1.el6sat.noarch
* foreman-vmware-1.6.0.42-1.el6sat.noarch
* katello-1.5.0-30.el6sat.noarch
* katello-ca-1.0-1.noarch
* katello-certs-tools-1.5.6-1.el6sat.noarch
* katello-installer-0.0.62-1.el6sat.noarch
* openldap-2.4.23-34.el6_5.1.x86_64
* openldap-devel-2.4.23-34.el6_5.1.x86_64
* pulp-katello-0.3-4.el6sat.noarch
* pulp-nodes-common-2.4.1-0.5.rc1.el6sat.noarch
* pulp-nodes-parent-2.4.1-0.5.rc1.el6sat.noarch
* pulp-puppet-plugins-2.4.1-0.5.rc1.el6sat.noarch
* pulp-puppet-tools-2.4.1-0.5.rc1.el6sat.noarch
* pulp-rpm-plugins-2.4.1-0.5.rc1.el6sat.noarch
* pulp-selinux-2.4.1-0.5.rc1.el6sat.noarch
* pulp-server-2.4.1-0.5.rc1.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.1.0-2.el6sat.noarch

Comment 8 Bryan Kearney 2014-09-11 12:29:11 UTC
This was delivered with Satellite 6.0 which was released on 10 September 2014.