Bug 1109467

Summary:	Review Request: perl-Term-Encoding - Detect encoding of the current terminal
Product:	[Fedora] Fedora	Reporter:	David Dick <ddick>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ddick, kevin, package-review, ppisar, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-19 05:40:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Dick 2014-06-14 06:00:40 UTC

Spec URL: http://ddick.fedorapeople.org/packages/perl-Term-Encoding.spec
SRPM URL: http://ddick.fedorapeople.org/packages/perl-Term-Encoding-0.02-1.fc20.src.rpm
Description: Detect encoding of the current terminal
Fedora Account System Username: ddick

Comment 1 David Dick 2014-06-14 06:01:25 UTC

koji builds at 

el6 http://koji.fedoraproject.org/koji/taskinfo?taskID=7044889

rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=7044887

Comment 2 Petr Šabata 2014-06-17 09:01:39 UTC

There are some missing BRs this time.  I understand those can be easily missed :)

perl(Exporter) -- via `use base', lib/Term/Encoding.pm:6
perl(ExtUtils::MM_Unix) -- required in version_from() and abstract_from() which are called from all_from(), Makefile.PL:4
perl(warnings) -- via the `no' keyword, lib/Term/Encoding.pm:12 and t/02_env.t:13

The rest is fine, as always.

Comment 3 David Dick 2014-06-17 09:12:21 UTC

No problems.

Fixed and uploaded.

Comment 4 Petr Šabata 2014-06-17 09:17:57 UTC

Ack.

Comment 5 David Dick 2014-06-17 09:24:05 UTC

New Package SCM Request
=======================
Package Name: perl-Term-Encoding
Short Description: Detect encoding of the current terminal
Upstream URL: http://search.cpan.org/dist/Term-Encoding/
Owners: ddick
Branches: f20 el6 epel7
InitialCC: perl-sig

Thanks again for the reviews Petr!

Comment 6 Kevin Fenzi 2014-06-18 16:30:44 UTC

Git done (by process-git-requests).

Comment 7 Kevin Fenzi 2014-06-18 16:37:04 UTC

Acutually, this looks like a dupe of https://bugzilla.redhat.com/show_bug.cgi?id=1094289 ?

Comment 8 Petr Pisar 2014-06-19 05:40:22 UTC

Certainly. Please revert the package ownership to ppisar.

*** This bug has been marked as a duplicate of bug 1094289 ***

Comment 9 Kevin Fenzi 2014-06-19 20:57:18 UTC

This was fixed up this morning.

Comment 10 Petr Pisar 2014-06-20 06:13:40 UTC

(In reply to David Dick from comment #5)
> New Package SCM Request
> =======================
> Package Name: perl-Term-Encoding
> Short Description: Detect encoding of the current terminal
> Upstream URL: http://search.cpan.org/dist/Term-Encoding/
> Owners: ddick
> Branches: f20 el6 epel7
> InitialCC: perl-sig
> 
If you need the package in these branches, I will do the f20 and arrange EPEL branches for you as the owner.

Comment 11 David Dick 2014-06-20 07:47:59 UTC

Yes, that would be great.  Sorry for the dup.