Bug 1110434
Summary: | Remote AlertDefinitionManager API does not handle template or group level definitions correctly | ||
---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | Jay Shaughnessy <jshaughn> |
Component: | Alerts, CLI, REST | Assignee: | Jay Shaughnessy <jshaughn> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 4.11 | CC: | hrupp |
Target Milestone: | GA | ||
Target Release: | RHQ 4.12 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-12-15 11:36:19 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jay Shaughnessy
2014-06-17 15:59:48 UTC
After some discussion it was decided that in fact these methods should handle any alert definition and do the right thing. The other option was to open up remote APIs/REST endpoints specific to each level of alert definition. This option was rejected for both usability and maintenance reasons, keeping the exposed API smaller and more flexible is preferred. commit 8d1ede47c80394e9bc7a587d21c1ed6b3baf9417 Author: Jay Shaughnessy <jshaughn> Date: Tue Jun 17 12:17:15 2014 -0400 - Repair the AlertDefinitionManagerRemote API such that enable/disable/remove methods operate on any combination of template,group or resource level alert definitions. - Properly jdoc the remote API methods, and improve some locals jdoc as well - Improve the transactioning to avoid a single umbrella transaction when invoking the API on multiple group and/or template alert definitions. - Convert GUI to use the enhanced remote API methods to benefit from the transactioning improvments and to shrink the generated Async API. - Improve i-test to use remote api and ensure child, resource-level alert defs are being handled properly. Also: - fix a problem with authz on alert template viewing. It should not require MANAGE_SETTINGS to view alert defs via getAlertDefinitionById(). - fix a long-standing bug where child alert-defs of templates or groups were not properly detached at remove-time of the parent, which could cause GUI failures when visiting the resource-level alert definitions. - remove some unused named queries from AlertDefinition Bulk close of items fixed in RHQ 4.12 If you think this is not solved, then please open a *new* BZ and link to this one. |