Bug 1111552

Summary:	[USS]: leak in snapview-client xlator in lookup and readdirp operations as per coverity
Product:	[Community] GlusterFS	Reporter:	Raghavendra Bhat <rabhat>
Component:	unclassified	Assignee:	Raghavendra Bhat <rabhat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1157982 (view as bug list)		Environment:
Last Closed:	2014-11-11 08:35:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1157982

Description Raghavendra Bhat 2014-06-20 10:24:20 UTC

Description of problem:
The system resource will not be reclaimed and reused, reducing the future availability of the resource.

In svc_readdirp: Leak of memory or pointers to system resources 

In SVC_STACK_UNWIND svc_local_free is called. But svc_local_free just wipes the contents of local. It is not freeing local. Since frame->local is set to NULL before unwinding, local is not put back into the mempool as part of FRAME_DESTROY also.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-06-20 10:28:44 UTC

REVIEW: http://review.gluster.org/8128 (features/snapview-client: put local back to mempool after unwind) posted (#1) for review on master by Raghavendra Bhat (raghavendra)

Comment 2 Anand Avati 2014-06-20 11:15:29 UTC

REVIEW: http://review.gluster.org/8128 (features/snapview-client: put local back to mempool after unwind) posted (#2) for review on master by Raghavendra Bhat (raghavendra)

Comment 3 Anand Avati 2014-06-23 07:40:07 UTC

COMMIT: http://review.gluster.org/8128 committed in master by Vijay Bellur (vbellur) 
------
commit a6620e3840bad41b84c590116183670cb1819667
Author: Raghavendra Bhat <raghavendra>
Date:   Fri Jun 20 15:54:57 2014 +0530

    features/snapview-client: put local back to mempool after unwind
    
    Change-Id: I3a709a835b21edf757ee5a1cd04cd9d1c59201dc
    BUG: 1111552
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/8128
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Niels de Vos 2014-09-22 12:43:25 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 5 Niels de Vos 2014-11-11 08:35:36 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users