Bug 1111673 (kdelibs-webkit)

Unfortunately, seems to be some problem with strigi, and scratch builds fail (on ppc64, though not sure if it's arch-specific or not yet).

Local builds on my x86_64 box go fine.

See also bug #1092693

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7073395

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Spec file name must match the spec package %{name}, in the format
  %{name}.spec. 

===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/include/kde4
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kdelibs-
     webkit-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define attica_ver 0.4.0, %define
     dbusmenu_qt_ver 0.9.0, %define phonon_ver 4.6.0, %define qt4_ver 4.8.1,
     %define shared_desktop_ontologies_ver 0.10.0, %define soprano_ver 2.8.0,
     %define strigi_ver 0.7.0, %define webkit 1, %define udisks udisks2,
     %define udisks2 1, %define upower 1, %define x_deps pkgconfig(sm)
     pkgconfig(xcomposite) pkgconfig(xdamage) pkgconfig(xkbfile)
     pkgconfig(xpm) pkgconfig(xproto) pkgconfig(xscrnsaver) pkgconfig(xtst)
     pkgconfig(xv) pkgconfig(xxf86misc)
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:

[!]: Spec file according to URL is the same as in SRPM.
     Note: Bad spec filename: /home/spstarr/1111673-kdelibs/srpm-
     unpacked/kdelibs.spec
     See: (this test has no URL)

--------

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.

Rpmlint
-------
Checking: kdelibs-webkit-4.10.5-1.el7.centos.x86_64.rpm
          kdelibs-webkit-devel-4.10.5-1.el7.centos.x86_64.rpm
          kdelibs-webkit-4.10.5-1.el7.centos.src.rpm
kdelibs-webkit.x86_64: W: incoherent-version-in-changelog 4.10.5-1 ['6:4.10.5-1.el7.centos', '6:4.10.5-1.centos']
kdelibs-webkit.x86_64: W: no-documentation
kdelibs-webkit-devel.x86_64: W: only-non-binary-in-usr-lib
kdelibs-webkit-devel.x86_64: W: no-documentation
kdelibs-webkit.src: E: invalid-spec-name
3 packages and 0 specfiles checked; 1 errors, 4 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint kdelibs-webkit-devel kdelibs-webkit
kdelibs-webkit-devel.x86_64: W: only-non-binary-in-usr-lib
kdelibs-webkit-devel.x86_64: W: no-documentation
kdelibs-webkit.x86_64: W: incoherent-version-in-changelog 4.10.5-1 ['6:4.10.5-1.el7.centos', '6:4.10.5-1.centos']
kdelibs-webkit.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkdewebkit.so.5.10.5 /lib64/libQtXml.so.4
kdelibs-webkit.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkdewebkit.so.5.10.5 /lib64/libnepomukutils.so.4
kdelibs-webkit.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkdewebkit.so.5.10.5 /lib64/libnepomuk.so.4
kdelibs-webkit.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkdewebkit.so.5.10.5 /lib64/libQtSvg.so.4
kdelibs-webkit.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkdewebkit.so.5.10.5 /lib64/libpthread.so.0
kdelibs-webkit.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkdewebkit.so.5.10.5 /lib64/libQtDBus.so.4
kdelibs-webkit.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkdewebkit.so.5.10.5 /lib64/libsoprano.so.4
kdelibs-webkit.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkdewebkit.so.5.10.5 /lib64/libm.so.6
kdelibs-webkit.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkdewebkit.so.5.10.5 /lib64/libgcc_s.so.1
kdelibs-webkit.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 13 warnings.
# echo 'rpmlint-done:'

For subpackage -devel, %{summary} entry isn't needed as given, Summary:   Development files for KDE WebKit support library

Spec URL: http://rdieter.fedorapeople.org/rpms/kdelibs-webkit/kdelibs-webkit.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdelibs-webkit/kdelibs-webkit-4.10.5-1.el7.src.rpm

%changelog
* Sat Jul 19 2014 Rex Dieter <rdieter> 4.10.5-2
- rename .spec to match pkg Name:


not sure what you mean in comment #4

I mean here:


%package devel
-------> Summary:   Development files for KDE WebKit support library
Provides:  kdelibs4-webkit-devel = %{version}-%{release}
%{?_isa:Provides: kdelibs4-webkit-devel%{?_isa} = %{version}-%{release}}
Requires: %{name}%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release}
Requires: kdelibs4-devel
Requires: pkgconfig(QtWebKit)
%description devel
-------> %{summary}. 


The %{summary} isn't needed? It's not critical either way

Oh, that's just a way to make the description match the Summary (I don't have anything better to put there).

Looks good, APPROVED!

New Package SCM Request
=======================
Package Name: kdelibs-webkit
Short Description: KDE WebKit support library
Upstream URL: https://projects.kde.org/projects/kde/kdelibs
Owners: rdieter
Branches: epel7
InitialCC:

Git done (by process-git-requests).

imported and built.