Bug 1111979 (kf5-kapidox)
| Summary: | Review Request: kf5-kapidox - KDE Frameworks 5 Tier 4 module with scripts and data for building API documentation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jeischma, jgrulich, package-review |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-07 13:06:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1086148 | ||
|
Description
Daniel Vrátil
2014-06-22 13:16:28 UTC
1) License should be probably only BSD, also your license field is not in correct format 2) Summary is too long 3) /usr/lib/python2.7/site-packages/kapidox/depdiagram/generate.py should be executable 4) Package should be probably noarch because it doesn't contain any binaries 5) Missing license file in %doc 6) BR should be python2-devel instead of python-devel Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kapidox.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kapidox-4.100.0-2.fc20.src.rpm - Fixed license - Fixed summary - Fixed BR - Fixed missing license - Made package noarch I don't think that generate.py should be executable. site-packages are like plugins, they are afaik loaded by running sripts and cannot be executed stand-alone. I also checked other site-packages in /usr/lib/python2.7 and none of them is executable either. Looks good now, approved. New Package SCM Request ======================= Package Name: kf5-kapidox Short Description: KDE Frameworks 5 Tier 4 scripts and data for building API documentation Upstream URL: http://www.kde.org Owners: dvratil ltinkl jgrulich kkofler rdieter than Branches: InitialCC: Git done (by process-git-requests). Package Change Request ======================= Package Name: kf5-kapidox New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than Git done (by process-git-requests). |