Bug 1111996

Summary:	Review Request: bit_rot_detector - Scans directories and files for damage due to decay of storage medium
Product:	[Fedora] Fedora	Reporter:	Jeff Backus <jeff.backus>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jtfas90, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-24 00:07:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeff Backus 2014-06-22 15:06:52 UTC

Spec URL: http://jsbackus.fedorapeople.org/bit_rot_detector/bit_rot_detector.spec
SRPM URL: http://jsbackus.fedorapeople.org/bit_rot_detector/bit_rot_detector-1.0-1.fc20.src.rpm
Description: 
bit_rot_detector, or brd, is a tool to scan a directory tree and check each file
for corruption caused by damage to the physical storage medium or by damage from
malicious programs. Files are fingerprinted using the SHA-1 algorithm. File
fingerprints, sizes, and modification times are stored in a SQLite database.

Fedora Account System Username: jsbackus

Comment 1 Christopher Meng 2014-06-22 15:10:56 UTC

Any chance of a shorter name?

Also for noarch python packages, no need to specify optflags.

Comment 2 Jason Taylor 2014-06-22 15:41:14 UTC

Hi Jeff,

Github Source URL definition is a bit different, take a look at 

https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL

a quick fedora-review check looks good though.

Comment 3 Jeff Backus 2014-06-24 00:01:57 UTC

(In reply to Christopher Meng from comment #1)
> Any chance of a shorter name?
> 
> Also for noarch python packages, no need to specify optflags.

Hi Christopher,

I was debating on whether to shorten the name or not. Since you asked, I decided I might as well. :) Shortened to brd.

I removed the optflags ref.

Thanks!

Regards,
Jeff

Comment 4 Jeff Backus 2014-06-24 00:06:47 UTC

(In reply to Jason Taylor from comment #2)
> Hi Jeff,
> 
> Github Source URL definition is a bit different, take a look at 
> 
> https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL
> 
> a quick fedora-review check looks good though.

Hi Jason,

Doh! Thanks for catching that. I modified the spec to meet guidelines.

Thanks!

Regards,
Jeff

Comment 5 Jeff Backus 2014-06-24 00:07:59 UTC

Since I've changed the name (I know, generally bad juju), I'm closing this bug and a new review request has been submitted:

https://bugzilla.redhat.com/show_bug.cgi?id=1112434

*** This bug has been marked as a duplicate of bug 1112434 ***