Bug 111254
| Summary: | nested assignment in assert | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | d.binderman |
| Component: | squid | Assignee: | Jay Fenlason <fenlason> |
| Status: | CLOSED RAWHIDE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 1 | CC: | jfeeney |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | squid-2.5.STABLE5-2 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2004-04-05 21:22:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
I included a patch for this in the latest rawhide squid rpm Patch merged into upstream, thanks to a very observant user who noticed this patch in Fedora. Regards Henrik Nordström Squid HTTP Proxy project |
Description of problem: I just tried to compile package squid-2.5.STABLE3-0 from Fedora. The compiler said 1. ntlm/auth_ntlm.c(683): warning #187: use of "=" where "==" may have been intended The source code is assert(auth_user->auth_type = AUTH_NTLM); This code might be better as assert(auth_user->auth_type == AUTH_NTLM); Putting assignments in asserts is not recommended. The assignment will disappear when asserts are switched off by the -DNDEBUG option. Version-Release number of selected component (if applicable): squid-2.5.STABLE3-0 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: